Remove 99-percentile columns from RecipeRunStats data table#6072
Merged
knutwannheden merged 7 commits intomainfrom Sep 25, 2025
Merged
Remove 99-percentile columns from RecipeRunStats data table#6072knutwannheden merged 7 commits intomainfrom
RecipeRunStats data table#6072knutwannheden merged 7 commits intomainfrom
Conversation
Currently, `RecipeRunStats` uses the default configuration for the timer's distribution statistic configuration, which uses an expiry of 1 minute and a buffer length of 3. This means that the 99-percentile reported by `RecipeRunStats` will in fact only be computed by the values recorded during the last minute of the recipe run. This commit addresses this by setting the expiry to 24 hours and also only using a buffer length of 1 (translating to one bucket in `TimeWindowPercentileHistogram`), so that there isn't any bias for recent scans/edits.
knutwannheden
changed the title
RecipeRunStats should cover the entire recipe runRecipeRunStats 99-percentile value should be cumulative
sambsnyd
approved these changes
Sep 25, 2025
github-project-automation
Bot
moved this from In Progress
to Ready to Review
in OpenRewrite
knutwannheden
changed the title
RecipeRunStats 99-percentile value should be cumulativeRecipeRunStats 99-percentile cumulative for entire recipe run
jkschneider
reviewed
Sep 25, 2025
Member
jkschneider
left a comment
jkschneider
left a comment
There was a problem hiding this comment.
I would prefer we simply remove these columns. The only operational use of P99 is in A/B testing and we haven’t ever operated something like that for multiple versions of recipes
knutwannheden
changed the title
RecipeRunStats 99-percentile cumulative for entire recipe runRecipeRunStats data table
knutwannheden
added a commit
to moderneinc/moderne-visualizations-misc
that referenced
this pull request
Sep 25, 2025
These weren't used anyway and the columns are about to get dropped from OpenRewrite: openrewrite/rewrite#6072
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only operational use of P99 is in A/B testing and we haven’t ever operated something like that for multiple versions of recipes.