Skip to content

Add JGit binary check for plain text acceptance#6116

Merged
shanman190 merged 1 commit intomainfrom
feat/better-plain-text
Oct 9, 2025
Merged

Add JGit binary check for plain text acceptance#6116
shanman190 merged 1 commit intomainfrom
feat/better-plain-text

Conversation

@shanman190
Copy link
Copy Markdown
Contributor

What's changed?

Use the same mechanism for plain text identification that Git utilizes.

What's your motivation?

To improve plain text identification. Retained the ability to explicitly use plainTextMasks as a first pass check, but it should no longer be necessary for most cases (UTF-16 encoded files can use plainTextMasks as an escape hatch as is typically done with .gitattributes).

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@shanman190 shanman190 self-assigned this Oct 9, 2025
@shanman190 shanman190 added the enhancement New feature or request label Oct 9, 2025
@github-project-automation github-project-automation Bot moved this to In Progress in OpenRewrite Oct 9, 2025
@shanman190 shanman190 force-pushed the feat/better-plain-text branch from daabaad to f604b33 Compare October 9, 2025 17:37
@shanman190 shanman190 merged commit a007100 into main Oct 9, 2025
2 of 3 checks passed
@shanman190 shanman190 deleted the feat/better-plain-text branch October 9, 2025 19:33
@github-project-automation github-project-automation Bot moved this from In Progress to Done in OpenRewrite Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

1 participant