Skip to content

Reduce allocations of Version to reduce GC impact#6296

Merged
kmccarp merged 3 commits intomainfrom
bugfix/gradle-resolved-avoid-recomputation
Nov 18, 2025
Merged

Reduce allocations of Version to reduce GC impact#6296
kmccarp merged 3 commits intomainfrom
bugfix/gradle-resolved-avoid-recomputation

Conversation

@shanman190
Copy link
Copy Markdown
Contributor

What's changed?

  • Perform cheaper string equality first
  • Cache the max version seen so far

What's your motivation?

Reducing GC pressure

Anything in particular you'd like reviewers to focus on?

N/A

Anyone you would like to review specifically?

@kmccarp

Have you considered any alternatives or workarounds?

N/A

Any additional context

N/A

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@shanman190 shanman190 requested a review from kmccarp November 15, 2025 02:03
@shanman190 shanman190 self-assigned this Nov 15, 2025
@shanman190 shanman190 added the bug Something isn't working label Nov 15, 2025
@github-project-automation github-project-automation Bot moved this to In Progress in OpenRewrite Nov 15, 2025
@github-project-automation github-project-automation Bot moved this from In Progress to Ready to Review in OpenRewrite Nov 15, 2025
@kmccarp kmccarp changed the title Further improvements to reduce GC pressure Reduce allocations of Version to reduce GC impact Nov 18, 2025
@kmccarp kmccarp merged commit b3c6ea4 into main Nov 18, 2025
@kmccarp kmccarp deleted the bugfix/gradle-resolved-avoid-recomputation branch November 18, 2025 15:36
@github-project-automation github-project-automation Bot moved this from Ready to Review to Done in OpenRewrite Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants