Fix Recipe to remove build cache configuration for Develocity

[div-bargali]

What's changed?

Added a unit test that fails with the current recipe to remove Develocity Build Cache Configuration.

Edit - Added a boolean flag (optional) removeBuildCache to RemoveDevelocityConfiguration recipe. When passed as true, it adds the buildCache extension in the settings.gradle(.kts) file for removal.

What's your motivation?

• Fixes Recipe to remove build cache configuration for Develocity #6466

Anything in particular you'd like reviewers to focus on?

Adding a test case that fails with the current implementation. Would like to contribute a fix that would remove the buildCache extension correctly.

Have you considered any alternatives or workarounds?

There are no workarounds.

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've used the IntelliJ IDEA auto-formatter on affected files

[div-bargali]

Hi Team,
Opening a PR to add unit test scenarios where the current recipe fails. Will capture the details in an issue.

[div-bargali]

Fixes Issue - #6466

[div-bargali]

Added the fix and updated the PR description to explain the fix.

I noticed that there is a composite recipe RemoveDevelocity that uses this recipe as well. (https://github.com/openrewrite/rewrite/blob/main/rewrite-gradle/src/main/resources/META-INF/rewrite/gradle.yml#L47)
Did not make any changes to it as I reckon it is best for users to explicitly pass the flag's value as true as there can be a case when Develocity's build cache is not configured through Gradle's buildCache extension but the extension is still present. Open to discuss on this.

[timtebeek]

Thanks for the help here @div-bargali ! I've condensed your work a bit by overriding getVisitor and applying some other best practices like ListUtils.filter. Great to see this resolved.

[div-bargali]

Thanks for the help here @div-bargali ! I've condensed your work a bit by overriding getVisitor and applying some other best practices like ListUtils.filter. Great to see this resolved.

Thanks @timtebeek. Glad I could help in contributing to the project!

[timtebeek]

All good; after discussing with Shannon we've added a small update to further limit what's removed vs retained.

• Only remove gradleEnterprise and develocity.buildCache #6476

[div-bargali]

All good; after discussing with Shannon we've added a small update to further limit what's removed vs retained.

• Only remove gradleEnterprise and develocity.buildCache #6476

Thanks for sharing @timtebeek . It makes sense to restrict removal of remote(HttpBuildCache) block, however I'd like to point out that I have seen Develocity's Build Cache being configured using the HTTP connector more often than the Develocity's connector.
Maybe in the future we can add an optional flag for users who want to also remove the HttpBuildCache's configuration after evaluation of any reported issue. Thanks!