Skip to content

Revert "Fixed situation where a changing a managed dependency that does not have an explicit version tag would fail to add a version tag when providing the newVersion option."#6564

Merged
greg-at-moderne merged 1 commit intomainfrom
revert-6105-1465-change-managed-dependency-can-add-version-tag-if-needed
Jan 19, 2026
Merged

Revert "Fixed situation where a changing a managed dependency that does not have an explicit version tag would fail to add a version tag when providing the newVersion option."#6564
greg-at-moderne merged 1 commit intomainfrom
revert-6105-1465-change-managed-dependency-can-add-version-tag-if-needed

Conversation

@greg-at-moderne
Copy link
Copy Markdown
Contributor

@greg-at-moderne greg-at-moderne commented Jan 19, 2026

- org.openrewrite.maven.ChangeDependencyGroupIdAndArtifactIdTest  
    - doesNotAddVersionNumberTagToDirectDependencyIfAbleToOnParentManagedDependency()  
    - doesNotAddVersionNumberTagToDirectDependencyIfAbleToOnManagedDependency()  
- org.openrewrite.maven.ChangeManagedDependencyGroupIdAndArtifactIdTest  
    - changeManagedDependencyMissingExplicitVersion()

Copy link
Copy Markdown
Contributor

@steve-aom-elliott steve-aom-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will re-review the changes post reverting and post Shannon's changes

@github-project-automation github-project-automation Bot moved this from In Progress to Ready to Review in OpenRewrite Jan 19, 2026
@greg-at-moderne greg-at-moderne merged commit 67cd777 into main Jan 19, 2026
2 checks passed
@greg-at-moderne greg-at-moderne deleted the revert-6105-1465-change-managed-dependency-can-add-version-tag-if-needed branch January 19, 2026 15:08
@github-project-automation github-project-automation Bot moved this from Ready to Review to Done in OpenRewrite Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants