Expand UpgradePluginVersion to support the kotlin plugin#6570
Merged
Expand UpgradePluginVersion to support the kotlin plugin#6570
UpgradePluginVersion to support the kotlin plugin#6570Conversation
Fix bug where `visitVariable` allowed the version to be downgraded
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…gradePluginVersion.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Jenson3210
reviewed
Jan 20, 2026
Contributor
Jenson3210
left a comment
Jenson3210
left a comment
There was a problem hiding this comment.
Looking at the code here made me realize we have a Trait GradlePlugin which we might be able to use here (similar to GradleDependency).
If we want to do that now or not, I honestly don't know without looking deeper into the existing Trait.
timtebeek
approved these changes
Jan 22, 2026
Member
timtebeek
left a comment
timtebeek
left a comment
There was a problem hiding this comment.
Looks good thanks! Ok to merge now with the understanding that there's a parallel PR, after which we can separately look to switch to the GradlePlugin trait.
github-project-automation
Bot
moved this from In Progress
to Ready to Review
in OpenRewrite
timtebeek
changed the title
UpgradePluginVersionUpgradePluginVersion to support the kotlin plugin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
The recipe no longer allows downgrading the version when it's defined as a variable (similar to
visitEntry)The recipe now works to upgrade the Kotlin plugin version
What's your motivation?
Working with Kotlin I ran into these two
Anything in particular you'd like reviewers to focus on?
Matching by simple name is generally discouraged but with a lack of type information I'm not sure how else to approach
Any additional context
Unfortunately the select does not have a
methodTypesoMethodMatcherwon't work hereChecklist