Fix flaky test by isolating Maven tests that modify user.home#6574
Merged
jkschneider merged 1 commit intomainfrom Jan 20, 2026
Merged
Fix flaky test by isolating Maven tests that modify user.home#6574jkschneider merged 1 commit intomainfrom
jkschneider merged 1 commit intomainfrom
Conversation
MavenSecuritySettingsTest and MavenSettingsTest modify the global user.home system property during tests. With parallel test execution enabled, other tests could pick up the modified property pointing to an empty temp directory, causing parse failures. Added @isolated annotation to ensure these tests run alone.
jkschneider
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@Isolatedannotation toMavenSecuritySettingsTestandMavenSettingsTestto prevent flaky test failuresProblem
The
rewrite-mavenmodule has parallel test execution enabled.MavenSecuritySettingsTestandMavenSettingsTestmodify the globaluser.homesystem property during tests. While these classes had@Execution(ExecutionMode.SAME_THREAD), this only prevents tests within the same class from running concurrently—other test classes can still run in parallel.When
ChangePluginGroupIdAndArtifactIdTestran concurrently withMavenSecuritySettingsTest, it could pick up the modifieduser.homepointing to a temp directory with an empty.m2directory, causing an "EOF in prolog" parse error when trying to readsettings.xml.Solution
Added
@Isolatedannotation to both test classes. This ensures they run completely alone with no other tests executing concurrently across the entire test suite.