AddOrUpdateAnnotationAttribute respects appendArray with string literals#6598
Merged
jkschneider merged 2 commits intomainfrom Jan 26, 2026
Merged
AddOrUpdateAnnotationAttribute respects appendArray with string literals#6598jkschneider merged 2 commits intomainfrom
jkschneider merged 2 commits intomainfrom
Conversation
When appendArray=true and the existing annotation value is a string literal (not already an array), the recipe now converts it to an array and appends the new values instead of replacing. Before: @foo(bars = "abc") + appendArray=true + value="xyz" → @foo(bars = "xyz") After: @foo(bars = "abc") + appendArray=true + value="xyz" → @foo(bars = {"abc", "xyz"}) Fixes moderneinc/customer-requests#1410
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
appendArray=trueand the existing annotation value is a string literal (not already an array), the recipe now converts it to an array and appends the new valuescreateNewArrayWithExistingAndNew()to handle the conversionProblem
AddOrUpdateAnnotationAttributedid not respect theappendArrayoption when the existing annotation value was a string literal rather than an array. It would replace the value instead of appending.Example:
@Foo(bars = "abc")withappendArray=trueandattributeValue="xyz"@Foo(bars = {"abc", "xyz"})@Foo(bars = "xyz")Solution
Added checks in
update(J.Assignment ...)andupdate(J.Literal ...)methods to detect whenappendArray=trueand the attribute is an array type but the current value is a literal. In these cases, we now convert the literal to an array containing both the existing value and the new values.Test plan
respectsAppendArrayWhenGoingFromImplicitLiteralValueToArray()addedrespectsAppendArrayWhenGoingFromLiteralToArraySingleandrespectsAppendArrayWhenGoingFromLiteralToArrayMultinow pass