Add Kotlin DSL variable downgrade tests for UpgradePluginVersion#6704
Closed
Add Kotlin DSL variable downgrade tests for UpgradePluginVersion#6704
Conversation
Add tests covering the scenario from customer-requests#1809 where UpgradePluginVersion with an exact version could downgrade plugins when versions are stored in a Kotlin DSL val variable shared across multiple plugin declarations. Also replace assert statements with proper null checks in the scanner for the GString and Identifier variable branches to avoid silent null storage when assertions are disabled.
MBoegers
force-pushed
the
mboegers/fix-upgrade-plugin-version-downgrade
branch
from
1c21f6d to
3004b88
Compare
Expand dontDowngradeKotlinDslSharedVariable to use the complete customer build file from customer-requests#1809, including all 5 Kotlin plugins, Spring Boot, dependency-management, application plugin, dependencies block, and toolchain configuration.
MBoegers
force-pushed
the
mboegers/fix-upgrade-plugin-version-downgrade
branch
from
3004b88 to
312d726
Compare
Member
|
This seems similar to another change I've seen come by; do we still need this PR? |
Contributor
Author
|
I don't think so, it was "just" a reproducer PR, can you linke the PR? |
Contributor
Author
|
retested and resolved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UpgradePluginVersionwith an exact version could downgrade plugins when versions are stored in a Kotlin DSLvalvariable shared across multiple plugin declarationsassertstatements with proper null checks in the scanner for the GString and Identifier variable branches to avoid silent null storage when assertions are disabledTest plan
dontDowngradeKotlinDslSharedVariable— verifies no downgrade with sharedvalvariable across multiple Kotlin pluginsdontDowngradeKotlinDslSinglePluginVariable— verifies no downgrade with single plugin using avalvariableupgradeKotlinDslSharedVariable— verifies upgrades work correctly with sharedvalvariableUpgradePluginVersionTesttests pass