Python: Fix MatchSequence parser incorrectly consuming child's delimiter#6713
Merged
knutwannheden merged 2 commits intomainfrom Feb 10, 2026
Merged
Python: Fix MatchSequence parser incorrectly consuming child's delimiter#6713knutwannheden merged 2 commits intomainfrom
MatchSequence parser incorrectly consuming child's delimiter#6713knutwannheden merged 2 commits intomainfrom
Conversation
When parsing `case [c], _:`, the outer implicit tuple MatchSequence was greedily consuming the `[` that belongs to the inner child MatchSequence. This caused the pattern to be parsed as a single bracketed list `[c, _]` instead of an implicit tuple containing `[c]` and `_`. The fix adds `__is_own_sequence_delimiter` which checks whether a `[` or `(` delimiter belongs to this MatchSequence or to its first child by combining AST inspection (is the first child also a MatchSequence?) with token peeking (are there consecutive delimiters?). Also includes RPC server improvements: relativeTo path support for parse inputs, bare string PathInput handling, and better error logging.
knutwannheden
changed the title
MatchSequence parser incorrectly consuming child's delimiter
jkschneider
reviewed
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When parsing
case [c], _:, the outer implicit tuple MatchSequence was greedily consuming the[that belongs to the inner child MatchSequence. This caused the pattern to be parsed as a single bracketed list[c, _]instead of an implicit tuple containing[c]and_.The fix adds
__is_own_sequence_delimiterwhich checks whether a[or(delimiter belongs to this MatchSequence or to its first child by combining AST inspection (is the first child also a MatchSequence?) with token peeking (are there consecutive delimiters?).Also includes RPC server improvements: relativeTo path support for parse inputs, bare string PathInput handling, and better error logging.