Python: changing how imports are parsed, prefer J.Import#6730
Merged
greg-at-moderne merged 4 commits intomainfrom Feb 13, 2026
Merged
Python: changing how imports are parsed, prefer J.Import#6730greg-at-moderne merged 4 commits intomainfrom
J.Import#6730greg-at-moderne merged 4 commits intomainfrom
Conversation
Single `import foo` statements no longer get unnecessarily wrapped in a `MultiImport` node. MultiImport is now only used when there are multiple names (`import foo, bar`). Updated parser, printer, and import recipes (add, remove, change) accordingly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…port-multiimport # Conflicts: # rewrite-python/rewrite/src/rewrite/python/_parser_visitor.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
Changing how imports are parsed for Python code.
Prefer
J.Import(the same AST element as for Java and other languages) if possible - i.e. there's a single import.Only use
MultiImportif not possible.What's your motivation?
Satisfy the objection of having as much LST re-use as reasonably possible.