Fix anchor on MappingStart in sequence entry losing prefix#6732
Merged
knutwannheden merged 1 commit intomainfrom Feb 13, 2026
Merged
Fix anchor on MappingStart in sequence entry losing prefix#6732knutwannheden merged 1 commit intomainfrom
knutwannheden merged 1 commit intomainfrom
Conversation
When a YAML anchor appeared on a MappingStart event inside a sequence (e.g. `- &b\n k2: v2`), the dash prefix was incorrectly truncated from the mapping's format string. This caused the SequenceBuilder to create an entry with isDash=false, producing `- k: v &b\n k2: v2` instead of preserving the original `- k: v\n- &b\n k2: v2`. The fix removes the dash-index truncation of `fmt` in the MappingStart anchor handling. The `fmt` is kept as-is so the SequenceBuilder can properly split it and preserve the dash indicator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MappingStartevent inside a sequence entry (e.g.- &b\n k2: v2)fmtin theMappingStartanchor handling was incorrectly stripping the-from the format string, causingSequenceBuilderto create entries withisDash=falseTest plan
anchorOnMappingInSequenceEntrypasses:rewrite-yaml:testsuite passes with no regressions