Fix htmlIndexToVersioning() HTML title attribute handling#6745
Merged
Fix htmlIndexToVersioning() HTML title attribute handling#6745
Conversation
…ttributes When parsing HTML directory listings, the method searched for "\">" to delimit the href attribute value. This overshoots when anchor tags include additional attributes like title="...", causing corrupted version strings such as "1.0.0/\" title=\"1.0.0" instead of "1.0.0/". The fix changes the search to find the closing quote directly, which correctly terminates at the href attribute boundary regardless of subsequent attributes. Includes a test case covering this scenario. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MavenPomDownloader.htmlIndexToVersioning()was corrupting version strings when parsing HTML directory listings that includetitleattributes on anchor tags.The method searched for
">to delimit thehrefattribute value, which overshoots when additional attributes follow (e.g.,title="..."). This resulted in corrupted version strings like1.0.0/" title="1.0.0instead of1.0.0/. Changed the search to look for the closing quote directly, which correctly terminates at the href attribute boundary regardless of other attributes.Includes test case covering HTML with title attributes on anchor tags.
🤖 Generated with Claude Code