Fix exponential overcounting in composite recipe listings#6796
Merged
jkschneider merged 1 commit intomainfrom Feb 23, 2026
Merged
Fix exponential overcounting in composite recipe listings#6796jkschneider merged 1 commit intomainfrom
jkschneider merged 1 commit intomainfrom
Conversation
The BFS loop in RecipeListing.fromDescriptor processed the root descriptor twice—once from the pre-initialized variable and again when polled from the queue—causing each level of the tree to be re-expanded, producing counts like 30k+ for deeply nested composites such as UpgradeToJava25.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RecipeListing.fromDescriptorprocessed the root descriptor twice (once from the pre-initializeddvariable and again when polled from the queue), causing each level of the tree to be re-expanded exponentiallyUpgradeToJava25reported 30k+ recipes instead of ~468