Skip to content

Remove maxHeapSize from JavaScriptRewriteRpc.Builder in favor of caller-provided NODE_OPTIONS #6803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pdelagrave merged 4 commits into from
Feb 25, 2026
Merged

Remove maxHeapSize from JavaScriptRewriteRpc.Builder in favor of caller-provided NODE_OPTIONS #6803

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4da2a6f
Remove `maxHeapSize` from `JavaScriptRewriteRpc.Builder` in favor of …
pdelagrave Feb 23, 2026
5a95636
Merge branch 'main' into nodeoptions
pdelagrave Feb 23, 2026
61d24c4
Merge branch 'main' into nodeoptions
pdelagrave Feb 24, 2026
5a78f05
Merge branch 'main' into nodeoptions
pdelagrave Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 2 additions & 26 deletions rewrite-javascript/src/main/java/org/openrewrite/javascript/rpc/JavaScriptRewriteRpc.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,6 @@ public static class Builder implements Supplier<JavaScriptRewriteRpc> {
private @Nullable Integer inspectBrk;
private @Nullable Path inspectBrkRewriteSourcePath;

private @Nullable Integer maxHeapSize;
private @Nullable Path workingDirectory;

public Builder marketplace(RecipeMarketplace marketplace) {
Expand Down Expand Up @@ -301,19 +300,6 @@ public Builder inspectBrk(Path rewriteDistPath) {
return inspectBrk(rewriteDistPath, 9229);
}

/**
* Set the maximum heap size for the Node.js process in megabytes.
* Default V8 heap size is approximately 1.5-2 GB on 64-bit systems.
* For large repositories with many source files, you may need to increase this.
*
* @param maxHeapSize Maximum heap size in megabytes (e.g., 4096 for 4GB)
* @return This builder
*/
public Builder maxHeapSize(@Nullable Integer maxHeapSize) {
this.maxHeapSize = maxHeapSize;
return this;
}

/**
* Set the working directory for the Node.js process.
* This affects where profile logs and other output files are generated.
Expand Down Expand Up @@ -341,7 +327,6 @@ public JavaScriptRewriteRpc get() {
"node",
"--enable-source-maps",
"--inspect-brk=" + inspectBrk,
maxHeapSize != null ? "--max-old-space-size=" + maxHeapSize : null,
serverJs.toAbsolutePath().normalize().toString(),
log == null ? null : "--log-file=" + log.toAbsolutePath().normalize(),
traceRpcMessages ? "--trace-rpc-messages" : null,
Expand Down Expand Up @@ -369,18 +354,9 @@ public JavaScriptRewriteRpc get() {
process.setWorkingDirectory(workingDirectory);
}

// Build NODE_OPTIONS with all necessary flags
StringBuilder nodeOptions = new StringBuilder("--enable-source-maps");
if (inspectBrk == null) {
// When not using inspect-brk, we need to pass Node.js flags via NODE_OPTIONS
// since npx spawns a child process
// Note: --prof is not allowed in NODE_OPTIONS for security reasons
if (maxHeapSize != null) {
nodeOptions.append(" --max-old-space-size=").append(maxHeapSize);
}
}
process.environment().putAll(environment);
process.environment().put("NODE_OPTIONS", nodeOptions.toString());
// caller-provided options, if any, are taking precedence over the options baked above
process.environment().merge("NODE_OPTIONS", " --enable-source-maps", (callerProvided, local) -> local + " " + callerProvided);
if (npxPath.getParent() != null) {
// `npx` is typically a shebang script alongside the `node` executable
process.environment().put("PATH", npxPath.getParent() + File.pathSeparator +
Expand Down
⚡