Skip to content

Remove reflective validation from ReplaceStringLiteralWithConstant #6825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
timtebeek wants to merge 1 commit into from
Closed

Remove reflective validation from ReplaceStringLiteralWithConstant #6825

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions rewrite-java/src/main/java/org/openrewrite/java/ReplaceStringLiteralWithConstant.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,25 +69,6 @@ public Validated<Object> validate() {
if (StringUtils.isBlank(fullyQualifiedConstantName)) {
return result.and(invalid(CONSTANT_FQN_PARAM, fullyQualifiedConstantName, "The constant's fully qualified name may not be empty or blank."));
}
if (StringUtils.isBlank(literalValue)) {
try {
Object constantValue = getConstantValueByFullyQualifiedName(fullyQualifiedConstantName);
if (constantValue == null) {
return result.and(invalid(CONSTANT_FQN_PARAM, fullyQualifiedConstantName, "Provided constant should not be null."));
}
if (!(constantValue instanceof String)) {
// currently, we only support string literals, also see visitor implementation
return result.and(invalid(CONSTANT_FQN_PARAM, fullyQualifiedConstantName, "Unsupported type of constant provided. Only literals can be replaced."));
}
return result;
} catch (ClassNotFoundException e) {
return result.and(invalid(CONSTANT_FQN_PARAM, fullyQualifiedConstantName, "No class for specified name was found."));
} catch (NoSuchFieldException e) {
return result.and(invalid(CONSTANT_FQN_PARAM, fullyQualifiedConstantName, "No field with specified name was found."));
} catch (IllegalAccessException e) {
return result.and(invalid(CONSTANT_FQN_PARAM, fullyQualifiedConstantName, "Unable to access specified field."));
}
}
return result;
}

Expand Down
Loading
⚡