Python: Add RPC codecs for PythonResolutionResult marker#6832
Merged
knutwannheden merged 1 commit intomainfrom Feb 26, 2026
Merged
Python: Add RPC codecs for PythonResolutionResult marker#6832knutwannheden merged 1 commit intomainfrom
PythonResolutionResult marker#6832knutwannheden merged 1 commit intomainfrom
Conversation
When PythonRewriteRpc.parseProject() adds a PythonResolutionResult
marker to setup.py on the Java side, the subsequent printAll() sends
this modified tree back to Python via the RPC diff protocol. Without
Python-side codecs, the marker couldn't be deserialized, causing a
message stream desync ("Expected positions array" error).
Add Python dataclasses and bidirectional RPC codecs (send + receive)
for PythonResolutionResult and its nested types: Dependency,
ResolvedDependency, SourceIndex, and PackageManager.
knutwannheden
changed the title
PythonResolutionResult marker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PythonRewriteRpc.parseProject()adds aPythonResolutionResultmarker tosetup.py(for projects with nopyproject.toml/setup.cfg), the subsequentprintAll()sends this modified tree back to Python via the RPC diff protocol. Without Python-side codecs, the marker couldn't be deserialized, causing a message stream desync ("Expected positions array" error).PythonResolutionResultand its nested types:Dependency,ResolvedDependency,SourceIndex, andPackageManager.rpcSend/rpcReceiveexactly.Test plan
parseFabricProjecttest passes: all 67 files from the fabric project parse and print correctly viaparseProject(), includingsetup.pywhich previously failedprintAll()output matches bytes on disk for all files