Python: Unwrap ExpressionStatement around block-level template placeholders#6838
Merged
knutwannheden merged 1 commit intomainfrom Feb 27, 2026
Merged
Python: Unwrap ExpressionStatement around block-level template placeholders#6838knutwannheden merged 1 commit intomainfrom
ExpressionStatement around block-level template placeholders#6838knutwannheden merged 1 commit intomainfrom
Conversation
…olders When a template has a placeholder in statement position (e.g. the body of a `with` block), the parser wraps it as ExpressionStatement(Identifier). If the replacement is a non-Expression statement (return, if, for, etc.), the visitor must substitute it directly in the block before the default visitor runs, so visit_expression_statement never tries to cast the replacement to Expression. This mirrors the JS template engine's visitBlock logic.
knutwannheden
changed the title
ExpressionStatement around block-level template placeholders
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
withblock), the parser wraps it asExpressionStatement(Identifier). If the replacement is a non-Expression statement (return,if,for, etc.), the visitor must substitute it directly in the block before the default visitor runs, sovisit_expression_statementnever tries to cast the replacement to Expression.visitBlocklogic.test_replacement.pyverifying the fix.Test plan
test_replacement.pypasses