Skip to content

Support empty JSP documents, or documents only containing comments#6846

Merged
timtebeek merged 2 commits intoopenrewrite:mainfrom
evie-lau:jspParsingFailures
Mar 2, 2026
Merged

Support empty JSP documents, or documents only containing comments#6846
timtebeek merged 2 commits intoopenrewrite:mainfrom
evie-lau:jspParsingFailures

Conversation

@evie-lau
Copy link
Copy Markdown
Contributor

@evie-lau evie-lau commented Feb 27, 2026

What's changed?

  • Adding some JSP tests that fail to parse.

    • These are failing tests. No fix included yet in first commit - may need help with implementation.
  • Attempted fix in b1c952c, included regenerating with gradle :rewrite-xml:generateAntlrSources

document
-    :   UTF_ENCODING_BOM? prolog element
+    :   UTF_ENCODING_BOM? prolog element?
    ;

@timtebeek timtebeek added bug Something isn't working xml parser labels Feb 27, 2026
@evie-lau evie-lau marked this pull request as ready for review February 27, 2026 17:51
@timtebeek timtebeek changed the title Add jsp failing parse testcases Support empty JSP documents, or documents only containing comments Mar 2, 2026
@timtebeek timtebeek moved this from In Progress to Ready to Review in OpenRewrite Mar 2, 2026
Copy link
Copy Markdown
Member

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the immediate fix here @evie-lau ! Great to see these covered. Should go out into a new release this Wednesday.

@timtebeek timtebeek merged commit b89fbd2 into openrewrite:main Mar 2, 2026
1 check passed
@github-project-automation github-project-automation Bot moved this from Ready to Review to Done in OpenRewrite Mar 2, 2026
@evie-lau evie-lau deleted the jspParsingFailures branch March 8, 2026 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working parser xml

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants