Fix print idempotency for annotated array type casts#6861
Merged
knutwannheden merged 1 commit intomainfrom Mar 3, 2026
Merged
Conversation
When javac represents `(@nullable Object[])` as `JCArrayTypeTree(JCAnnotatedType(@nullable, JCIdent(Object)))`, the `arrayTypeTree` method stripped the JCAnnotatedType wrapper without collecting its annotations, causing the cursor to advance over the annotation text and produce garbled output like `(Objectble Object[])`. The fix collects annotations from inner JCAnnotatedType wrappers during the tree walk (guarded by `count > 0` to avoid double-collecting when called from `visitAnnotatedType`), consumes them as leading annotations before the element type, and wraps the result in `J.AnnotatedType` when leading annotations are present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(@Nullable Object[])which was printed as(Objectble Object[])JCArrayTypeTree(JCAnnotatedType(@Nullable, JCIdent(Object))), thearrayTypeTreemethod stripped theJCAnnotatedTypewrapper without collecting its annotations, causing the cursor to advance over annotation text and produce corrupt outputJ.AnnotatedTypewhen neededTest plan
annotatedArrayTypeCasttest for simple cast(@Nullable Object[]) oannotatedArrayTypeCastInExpressiontest matching the original bug report pattern