Fix IllegalArgumentException in KotlinParser when dependsOn paths are relative#6882
Merged
jkschneider merged 2 commits intomainfrom Mar 5, 2026
Merged
Fix IllegalArgumentException in KotlinParser when dependsOn paths are relative#6882jkschneider merged 2 commits intomainfrom
jkschneider merged 2 commits intomainfrom
Conversation
…re relative `dependsOn` inputs created via `determinePath` have relative paths, but source inputs may have absolute paths. When `relativeTo` is absolute, resolve dependsOn paths against it so `Path.relativize` in `getRelativePath` doesn't throw `IllegalArgumentException` due to an absolute/relative mismatch.
…Path The new test demonstrates the IllegalArgumentException that occurs when dependsOn provides relative paths but relativeTo is absolute (e.g. a @tempdir). Also adds the absolute/relative mismatch guard directly in Parser.Input.getRelativePath, which is called from KotlinTreeParserVisitor.
timtebeek
approved these changes
Mar 5, 2026
github-project-automation
Bot
moved this from In Progress
to Ready to Review
in OpenRewrite
shanman190
approved these changes
Mar 5, 2026
|
Could you trigger a rebuild of gradle plugin with this fix included? |
Member
|
Hi @asbachb ; the fix should already be available through our snapshot versions; we'll resume our regular release schedule next week. Hope that helps! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dependsOninputs created viadeterminePathhave relative paths, but source inputs may have absolute pathsrelativeTois absolute,Path.relativizethrowsIllegalArgumentExceptiondue to the absolute/relative mismatchrelativeTobefore relativizing, preventing the crashTest plan