Skip redundant property override in child when parent declares same dependency#6955
Merged
Skip redundant property override in child when parent declares same dependency#6955
Conversation
…declares dependency When UpgradeDependencyVersion processes a managed dependency whose version is a property, and a local parent POM also declares the same dependency, the parent will handle the property change. The child should skip it to avoid a redundant property override. Fixes #6945
timtebeek
reviewed
Mar 24, 2026
| dm.getRequested().getVersion().length() - 1), | ||
| newerVersion, overrideManagedVersion, false).getVisitor()); | ||
| // if a local parent also declares this dependency, it will handle the property change | ||
| if (!isDeclaredByLocalParent(d.getGroupId(), d.getArtifactId())) { |
Member
There was a problem hiding this comment.
Should we maybe only skip if the version is null here? To avoid that we keep a version that then pins back a newer version from a parent? Or is that concern already handled separately?
Contributor
Author
There was a problem hiding this comment.
yes good call applied
Addresses review feedback: if the local parent declares the same dependency with an explicit version, it will update the version tag directly and won't handle the property change. The child must still add the property override in that case.
sambsnyd
approved these changes
Mar 31, 2026
github-project-automation
Bot
moved this from In Progress
to Ready to Review
in OpenRewrite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
UpgradeDependencyVersionprocesses a managed dependency whose version is a property (e.g.${flyway.version}), it now checks if a local parent POM also declares the same<dependency>. If so, the parent will be processed by the same recipe and will handle the property change — the child skips the redundant override.Adds
isDeclaredByLocalParent()helper that walks up the local parent chain checking for declared dependencies (not just managed ones), complementing the existingisManagedByLocalParent()method.Fixes UpgradeDependencyVersion with overrideManagedVersion does not add property if <relativePath> is missing #6945
Test plan
UpgradeDependencyVersionTest.upgradeVersionDefinedViaImplicitPropertyInRemoteParentOfLocalParent_withoutRelativePath— parent and child both declare flyway-core, property only added to parentUpgradeDependencyVersionTestsuite passes (no regressions)ChangePropertyValueTestandAddPropertyTestsuites pass