Don't append display name suffix to data table file keys#7104
Merged
jkschneider merged 1 commit intomainfrom Mar 23, 2026
Merged
Don't append display name suffix to data table file keys#7104jkschneider merged 1 commit intomainfrom
jkschneider merged 1 commit intomainfrom
Conversation
`CsvDataTableStore.fileKey()` always appended a sanitized suffix derived from `getInstanceName()`, which defaults to the display name. This meant every data table got a suffix like `--recipe-performance-c5de` even when no custom instance name was set and no disambiguation was needed. Now, when no group is set, a suffix is only added when the instance name was explicitly customized via `withInstanceName()` (i.e. differs from the default display name). Plain data tables like `RecipeRunStats` get a clean key: `org.openrewrite.table.RecipeRunStats`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CsvDataTableStore.fileKey()was always appending a sanitized suffix from the data table's display name (e.g.RecipeRunStats--recipe-performance-c5de), even when no custom instance name was set and no disambiguation was needed.withInstanceName(), or when a group is set. Plain data tables get a clean key likeorg.openrewrite.table.RecipeRunStats.Test plan
fileKeyNoSuffixWhenInstanceNameNotCustomized— verifies bare name when no customizationfileKeySuffixWhenInstanceNameCustomized— verifies suffix present withwithInstanceName()fileKeySuffixFromGroup— verifies suffix present withwithGroup()DataTableStoreTesttests pass