Support changing from a constructor to a factory method in ChangeMethodTargetToStatic#7281
Merged
Support changing from a constructor to a factory method in ChangeMethodTargetToStatic#7281
Conversation
…odTargetToStatic (#1804)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ChangeMethodTargetToStaticnow handles<constructor>method patterns by adding avisitNewClassoverride that converts matchednew Foo(args)calls intoTargetType.Foo(args)static method invocations. The constructor's simple class name becomes the initial method name, so users chainChangeMethodNameto get the final name (e.g.,getLogger). Anonymous class instantiations and inner class constructors are skipped. The visitor base class was changed fromJavaIsoVisitortoJavaVisitorto allow returningJ.MethodInvocationfromvisitNewClass.Test plan
constructorToStaticMethod— full chain withChangeMethodNamematching the issue's use caseconstructorToStaticMethodWithReturnType— verifies thereturnTypeoption worksconstructorWithAnonymousBodyNotChanged— anonymous class bodies left unchangedChangeMethodTargetToStaticTesttests still pass