Fix NPE in UpgradeDependencyVersion ext property upgrade#7299
Merged
Conversation
… is unresolvable DependencyVersionSelector.select() can return null when no matching version is found. The downgrade prevention code added in #7290 passes this null into versionComparator.upgrade() via singletonList(selectedVersion), which then calls RELEASE_PATTERN.matcher(null) and throws NullPointerException. Add a null guard consistent with the pattern used elsewhere in the same file (e.g., line 480). Fixes downstream failure in moderneinc/rewrite-spring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
selectedVersionin the ext property upgrade path ofUpgradeDependencyVersion, fixing NPE whenDependencyVersionSelector.select()returns nullProblem
selectedVersion(which is@Nullable) intoversionComparator.upgrade()without a null check. Whenselect()returns null (e.g., no matching version found),RELEASE_PATTERN.matcher(null)throwsNullPointerException.Stack trace from downstream CI:
Fix
Add a null check for
selectedVersionbefore the upgrade check, consistent with the same pattern used elsewhere in the file (e.g., line 480).Test plan
UpgradeDependencyVersionTest.doesNotDowngradeExtPropertyVersionpassesUpgradeDependencyVersionTesttests pass