Fix MavenDependency#findNewerVersion ExactVersion edge cases#7305
Merged
Fix MavenDependency#findNewerVersion ExactVersion edge cases#7305
Conversation
Closes #5062 - Add early exit for ExactVersion before downloading metadata when the target version is not an upgrade from the current version, avoiding unnecessary HTTP traffic. - Fix the corrupt-metadata fallback to verify the exact version is actually an upgrade before returning it, instead of returning it unconditionally.
Jenson3210
approved these changes
Apr 7, 2026
github-project-automation
Bot
moved this from In Progress
to Ready to Review
in OpenRewrite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes MavenDependency#findNewerVersion - unnecessary downloads, edge cases #5062
Early exit for ExactVersion: Before downloading Maven metadata, checks whether the exact target version is actually an upgrade from the current version. If not (same version or a downgrade), returns
nullimmediately, avoiding unnecessary HTTP traffic.Fix corrupt-metadata fallback: The fallback path for incomplete Maven metadata (e.g. MapR repository) previously returned the exact version unconditionally if the POM was downloadable. Now it verifies the version is an actual upgrade, consistent with how
VersionComparator.upgrade()works.Test plan
./gradlew :rewrite-maven:test --tests "*UpgradeDependencyVersion*"— all pass./gradlew :rewrite-maven:test --tests "*MavenDependency*"— all pass