ChangeDependency skips dependencies whose new coordinates don't resolve

rewrite-gradle/src/main/java/org/openrewrite/gradle/ChangeDependency.java

@@ -162,9 +162,15 @@ public Validated<Object> validate() {
         ));
     }
 
+    private boolean isGlobPattern() {
+        return oldGroupId.contains("*") || oldGroupId.contains("?") ||
+               oldArtifactId.contains("*") || oldArtifactId.contains("?");
+    }
+
     public static class Accumulator {
         Map<String, Object> versionVariableUpdates = new HashMap<>();
         Map<String, Set<GroupArtifact>> versionVariableUsages = new HashMap<>();
+        Set<GroupArtifact> failedResolutions = new HashSet<>();
     }
 
     @Override
@@ -232,7 +238,14 @@ private void resolveAndRecordVersion(String varName, J.MethodInvocation m, Gradl
                         acc.versionVariableUpdates.put(varName, resolvedVersion);
                     }
                 } catch (MavenDownloadingException e) {
-                    acc.versionVariableUpdates.put(varName, e);
+                    if (isGlobPattern()) {
+                        acc.failedResolutions.add(new GroupArtifact(dep.getGroupId(), dep.getArtifactId()));
+                        // Don't overwrite a successful resolution with a failure from a different artifact
+                        // sharing the same version variable (e.g. hibernate-core resolved but hibernate-validator didn't)
+                        acc.versionVariableUpdates.putIfAbsent(varName, e);
+                    } else {
+                        acc.versionVariableUpdates.put(varName, e);
+                    }
                 }
             }
         };
@@ -329,8 +342,8 @@ public J.VariableDeclarations.NamedVariable visitVariable(J.VariableDeclarations
                     return v;
                 }
                 Object scanResult = acc.versionVariableUpdates.get(v.getSimpleName());
-                if (scanResult instanceof Exception) {
-                    return Markup.warn(v, (Exception) scanResult);
+                if (scanResult instanceof MavenDownloadingException) {
+                    return Markup.warn(v, (MavenDownloadingException) scanResult);
                 }
                 if (scanResult instanceof String && v.getInitializer() instanceof J.Literal) {
                     String resolvedVersion = (String) scanResult;
@@ -347,6 +360,10 @@ private boolean canUpdateVariable(String varName) {
             }
 
             private J.MethodInvocation updateDependency(J.MethodInvocation m, GradleDependency dep, ExecutionContext ctx) {
+                if (acc.failedResolutions.contains(new GroupArtifact(dep.getGroupId(), dep.getArtifactId()))) {
+                    return m;
+                }
+
                 GradleDependency updated = dep;
 
                 if (!StringUtils.isBlank(newGroupId)) {
@@ -359,7 +376,7 @@ private J.MethodInvocation updateDependency(J.MethodInvocation m, GradleDependen
                 String varName = dep.getVersionVariable();
                 if (varName != null && !canUpdateVariable(varName)) {
                     Object scanResult = acc.versionVariableUpdates.get(varName);
-                    if (scanResult instanceof Exception) {
+                    if (scanResult instanceof MavenDownloadingException) {
                         return ((MavenDownloadingException) scanResult).warn(m);
                     }
                     if (scanResult instanceof String) {
@@ -485,8 +502,8 @@ public Properties visitEntry(Properties.Entry entry, ExecutionContext ctx) {
                                     return entry;
                                 }
                                 Object scanResult = acc.versionVariableUpdates.get(entry.getKey());
-                                if (scanResult instanceof Exception) {
-                                    return Markup.warn(entry, (Exception) scanResult);
+                                if (scanResult instanceof MavenDownloadingException) {
+                                    return Markup.warn(entry, (MavenDownloadingException) scanResult);
                                 }
                                 if (scanResult instanceof String) {
                                     String resolvedVersion = (String) scanResult;
@@ -514,6 +531,9 @@ private boolean canUpdateVariable(String varName, DependencyMatcher depMatcher,
             if (!depMatcher.matches(ga.getGroupId(), ga.getArtifactId())) {
                 return false;
             }
+            if (acc.failedResolutions.contains(ga)) {
+                return false;
+            }
         }
         return true;
     }

rewrite-gradle/src/test/java/org/openrewrite/gradle/ChangeDependencyTest.java

@@ -1104,4 +1104,43 @@ void isNotAcceptableForPlainTextWithGradleProjectMarker() {
                                 .build())));
         assertThat(visitor.isAcceptable(sourceFile, new InMemoryExecutionContext())).isFalse();
     }
+
+    @Test
+    void doesNotChangeGroupIdWhenNewCoordinatesDontResolve() {
+        rewriteRun(
+          spec -> spec.recipe(new ChangeDependency("org.hibernate", "hibernate-*", "org.hibernate.orm", null, "6.0.x", null, null, true)),
+          buildGradle(
+            """
+              plugins {
+                  id "java-library"
+              }
+
+              repositories {
+                  mavenCentral()
+              }
+
+              def hibernateVersion = '5.6.15.Final'
+              dependencies {
+                  implementation "org.hibernate:hibernate-core:${hibernateVersion}"
+                  implementation "org.hibernate:hibernate-validator:${hibernateVersion}"
+              }
+              """,
+            """
+              plugins {
+                  id "java-library"
+              }
+
+              repositories {
+                  mavenCentral()
+              }
+
+              def hibernateVersion = '5.6.15.Final'
+              dependencies {
+                  implementation "org.hibernate.orm:hibernate-core:6.0.2.Final"
+                  implementation "org.hibernate:hibernate-validator:${hibernateVersion}"
+              }
+              """
+          )
+        );
+    }
 }

rewrite-maven/src/main/java/org/openrewrite/maven/ChangeDependencyGroupIdAndArtifactId.java

@@ -114,6 +114,11 @@ public ChangeDependencyGroupIdAndArtifactId(String oldGroupId, String oldArtifac
         this.changeManagedDependency = changeManagedDependency;
     }
 
+    private boolean isGlobPattern() {
+        return oldGroupId.contains("*") || oldGroupId.contains("?") ||
+               oldArtifactId.contains("*") || oldArtifactId.contains("?");
+    }
+
     String displayName = "Change Maven dependency";
 
     @Override
@@ -391,6 +396,9 @@ public Xml visitTag(Xml.Tag tag, ExecutionContext ctx) {
                                 deferUpdate = true;
                             }
                         } catch (MavenDownloadingException e) {
+                            if (isGlobPattern()) {
+                                return tag;
+                            }
                             return e.warn(tag);
                         }
                     }

rewrite-maven/src/main/java/org/openrewrite/maven/ChangeManagedDependencyGroupIdAndArtifactId.java

@@ -101,6 +101,11 @@ public ChangeManagedDependencyGroupIdAndArtifactId(String oldGroupId, String old
         this.versionPattern = versionPattern;
     }
 
+    private boolean isGlobPattern() {
+        return oldGroupId.contains("*") || oldGroupId.contains("?") ||
+               oldArtifactId.contains("*") || oldArtifactId.contains("?");
+    }
+
     @Override
     public Validated<Object> validate() {
         Validated<Object> validated = super.validate();
@@ -177,6 +182,9 @@ public Xml.Tag visitTag(Xml.Tag tag, ExecutionContext ctx) {
                                 }
                             }
                         } catch (MavenDownloadingException e) {
+                            if (isGlobPattern()) {
+                                return tag;
+                            }
                             return e.warn(t);
                         }
                     }