Suppress spurious MockWebServer crash warnings in CI logs#7357
Merged
Suppress spurious MockWebServer crash warnings in CI logs#7357
Conversation
Route java.util.logging through SLF4J via jul-to-slf4j bridge, which discards the output through the existing slf4j-nop binding in tests. This suppresses StringIndexOutOfBoundsException crash logs from MockWebServer when normalizeRepository() probes HTTPS on HTTP-only mock servers. Also fix flaky useHttpWhenHttpsFails test by switching from enqueue to Dispatcher to avoid TLS probe bytes consuming the single enqueued response.
Member
Author
|
Much cleaner: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
java.util.loggingthrough SLF4J via thejul-to-slf4jbridge, which discards output through the existingslf4j-nopbinding in testsStringIndexOutOfBoundsExceptioncrash logs from MockWebServer whennormalizeRepository()probes HTTPS on HTTP-only mock serversuseHttpWhenHttpsFailstest by switching fromenqueuetoDispatcher, avoiding TLS probe bytes consuming the single enqueued responseTest plan
mirrorsAndAuth,useHttpWhenHttpsFails,latestOrReleaseVersionInDependencyManagement, andsystemPropertyTakesPrecedencepass with no MockWebServer crash outputuseHttpWhenHttpsFailsmultiple times to confirm flakiness is resolved