Scala parser: eliminate J.Unknown, add S types for Scala-specific constructs#7375
Merged
jkschneider merged 1 commit intomainfrom Apr 14, 2026
Merged
Scala parser: eliminate J.Unknown, add S types for Scala-specific constructs#7375jkschneider merged 1 commit intomainfrom
jkschneider merged 1 commit intomainfrom
Conversation
ddfef2c to
d70a6da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
visitUnknownnow throwsUnsupportedOperationExceptioninstead of producingJ.Unknown— gaps surface immediately as test failuresS.StatementExpression(replacesS.BlockExpression) — wraps anyJto make it both Statement and Expression, followingK.StatementExpressionpatternS.TypeAscription— proper S type forexpr: Type(notJ.TypeCast)S.TypeAlias— type alias declarations (type Foo = Bar)S.PatternDefinition— destructuring declarations, enum cases, given definitionsJ.Lambdachain withCurriedmarkerOmitBracesmarker on blocks without source braces; printer skips{ }New parser handlers
ParsedTry,This,InterpolatedString,SymbolLit,NamedArg,ByNameTypeTree,TypeBoundsTree,TypeApply(classOf),Alternativecatch patterns,Bind(at-binding), match case guardsFixes
/*__p0__*/comment in method name prefix for parameter detection:in given declarations preserved via varargs fieldJ.Returnwrapper;OmitBraceson braceless blocksTest plan