Conversation
…ng dependency versions.
…ng dependency versions.
Jenson3210
reviewed
Apr 20, 2026
Comment on lines
+1017
to
+1019
| private List<ResolvedDependency> doResolveDependencies(Scope scope, Map<GroupArtifact, VersionRequirement> requirements, | ||
| boolean resolveTransitives, | ||
| MavenPomDownloader downloader, ExecutionContext ctx) throws MavenDownloadingExceptions { |
Contributor
There was a problem hiding this comment.
Not all customers are on cli v4 yet. Won't this break for them also?
Questioning if this change is worth introducing a cli v3 release due to widespread impact.
Contributor
There was a problem hiding this comment.
I'm not sure I understand the concern @Jenson3210, this method is new code? The old code will continue to work?
Contributor
There was a problem hiding this comment.
Oh, nevermind. I missed the private part here as I was going over it...
Got confused with the newly added public one here and thought recipes were using this one instead of the other one which would throw NoSuchMethod.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In environments with very slow artifact repositories any unnecessary request can dramatically slow recipe runs.
I observed that UpgradeDependencyVersion is unintentionally eagerly resolving the poms of transitive dependencies post-upgrade of a direct dependency.
These alterations lead to further deferral of transitive resolution until something actually needs it.