Skip to content

Fix Ubuntu EOL tests#7522

Merged
greg-at-moderne merged 1 commit intomainfrom
greg-docker-eol-plucky
Apr 29, 2026
Merged

Fix Ubuntu EOL tests#7522
greg-at-moderne merged 1 commit intomainfrom
greg-docker-eol-plucky

Conversation

@greg-at-moderne
Copy link
Copy Markdown
Contributor

@greg-at-moderne greg-at-moderne commented Apr 29, 2026 •
edited
Loading

What's changed?

Update the assertions in the FindEndOfLifeImagesTest.

What's your motivation?

Ubuntu 26.04 plucky got released and the tests started failing with messages like:

DockerBestPracticesTest > appliesBestPractices() FAILED
    org.opentest4j.AssertionFailedError: [Unexpected result in "Dockerfile":
    diff --git a/Dockerfile b/Dockerfile
    index 9aabf8a..9482945 100644
    --- a/Dockerfile
    +++ b/Dockerfile
    @@ -1,4 +1,4 @@ 
    -~~(EOL: ubuntu:20.04 (ended 2025-05-31, suggest noble (24.04)))~~>~~(Missing HEALTHCHECK instruction)~~>FROM ubuntu:20.04
    +~~(EOL: ubuntu:20.04 (ended 2025-05-31, suggest plucky (26.04)))~~>~~(Missing HEALTHCHECK instruction)~~>FROM ubuntu:20.04

The trigger was d49a26b

@github-project-automation github-project-automation Bot moved this to In Progress in OpenRewrite Apr 29, 2026
@greg-at-moderne greg-at-moderne marked this pull request as ready for review April 29, 2026 11:38
@greg-at-moderne greg-at-moderne merged commit 3964f44 into main Apr 29, 2026
1 check passed
@greg-at-moderne greg-at-moderne deleted the greg-docker-eol-plucky branch April 29, 2026 11:38
@github-project-automation github-project-automation Bot moved this from In Progress to Done in OpenRewrite Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@greg-at-moderne greg-at-moderne

Labels

None yet

Projects

OpenRewrite
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@greg-at-moderne
⚡