Gradle: rename mainClassName to mainClass in application block#7540
Merged
Gradle: rename mainClassName to mainClass in application block#7540
mainClassName to mainClass in application block#7540Conversation
The `mainClassName` property on the application extension was deprecated
in Gradle 6.4 and removed in Gradle 9.0. Add a recipe that renames it
inside the `application { ... }` block (Groovy and Kotlin DSL) and wire
it into `MigrateToGradle9`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
mainClassNameproperty on the Gradleapplicationextension was deprecated in Gradle 6.4 and removed in Gradle 9.0. This addsorg.openrewrite.gradle.gradle9.UseMainClassPropertyForApplication, which renamesmainClassNametomainClassinside theapplication { ... }block (Groovy and Kotlin DSL), and wires it intoMigrateToGradle9alongside the existingUseMainClassProperty(which handlesJavaExec.main).The recipe uses a cursor-message guard so it only fires inside an
applicationinvocation, leaving unrelated identifiers (e.g.ext { mainClassName = ... }) untouched. Top-levelmainClassName = "..."(the rare convention-property case) is intentionally out of scope — wrapping that into a synthesizedapplicationblock is materially more complex and best handled separately if it surfaces in real codebases.Test plan
./gradlew :rewrite-gradle:test --tests "*UseMainClassPropertyForApplicationTest"./gradlew :rewrite-gradle:test --tests "*MigrateToGradle9Test"