InlineMethodCalls: preserve method select when replacement is bare#7551
Merged
InlineMethodCalls: preserve method select when replacement is bare#7551
Conversation
When the original invocation has a select (`red.getTotalHits()`) and the replacement template is a bare method call (`getTotalHitsCount()`), prepend the select so the result is `red.getTotalHitsCount()` instead of dropping the receiver. Fixes #7549
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the original invocation has a select (e.g.
red.getTotalHits()) and the replacement template is a bare method call (e.g.getTotalHitsCount()), the select was being dropped, producinggetTotalHitsCount()instead ofred.getTotalHitsCount(). This change detects that case and prepends#{this:any()}.to the template so the original receiver is preserved.Inline method callsshould keep method select if required #7549Test plan
preserveSelectWhenReplacementIsBareMethodCallcovers the bug caseInlineMethodCallsTesttests still pass