Skip to content

Go: Fix comments within method invocation#7561

Merged
greg-at-moderne merged 2 commits intomainfrom
greg-go-selector-comment
May 5, 2026
Merged

Go: Fix comments within method invocation#7561
greg-at-moderne merged 2 commits intomainfrom
greg-go-selector-comment

Conversation

@greg-at-moderne
Copy link
Copy Markdown
Contributor

@greg-at-moderne greg-at-moderne commented May 4, 2026

What's changed?

Fix parsing of Go code with comments in the middle of the method invocation, e.g.

unsafe /* a comment */ .Alignof(x)

What's your motivation?

This suffers from idempotency issues.

@greg-at-moderne greg-at-moderne changed the title Go: Fix comments within field access Go: Fix comments within method invocation May 5, 2026
@greg-at-moderne greg-at-moderne marked this pull request as ready for review May 5, 2026 02:49
@greg-at-moderne greg-at-moderne merged commit 550c442 into main May 5, 2026
1 check passed
@greg-at-moderne greg-at-moderne deleted the greg-go-selector-comment branch May 5, 2026 02:49
@github-project-automation github-project-automation Bot moved this from In Progress to Done in OpenRewrite May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant