Fix UpdateGradleWrapper emitting malformed CLASSPATH for Gradle 8.14+#7565
Closed
Fix UpdateGradleWrapper emitting malformed CLASSPATH for Gradle 8.14+#7565
Conversation
The pre-computed unix wrapper scripts for Gradle 8.14.x and 9.0.x contained `CLASSPATH="\\\"\\\""` instead of the empty `CLASSPATH=` emitted by the official Gradle wrapper template. Set the binding to empty (matching the 9.1.0+ branch) and remove the compensating post-processing replace, then regenerate the affected resource files. Fixes #7564
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UpdateGradleWrapperemittedCLASSPATH="\\\"\\\""instead of the officialCLASSPATH=for the pre-computed unix wrapper scripts targeting Gradle 8.14.x through 9.0.x.classpathbinding inGradleWrapperScriptDownloader.unixBindings()to""for both the 8.14-rc-1+ and 9.0-milestone-2+ ranges (matching the existing 9.1.0+ branch), and removes the compensating.replace()inrenderTemplate().b67a59d5.txt→8e765725.txt,665958e3.txt→47c95633.txt), updatedversions.csv, and corrected thegradlew-8.14test fixture.Test plan
./gradlew :rewrite-gradle:test --tests "org.openrewrite.gradle.UpdateGradleWrapperTest"(34 passing, includingusesExecutableJarFrom8_14)./gradlew :rewrite-gradle:test --tests "org.openrewrite.gradle.internal.GradleWrapperScriptLoaderTest" --tests "org.openrewrite.gradle.internal.GradleWrapperTest"