Skip to content

JS: fix npmPublish skip detection that always reported "already published" #7570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
greg-at-moderne merged 2 commits into from
May 5, 2026
Merged

JS: fix npmPublish skip detection that always reported "already published" #7570

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6793871
JS: fix npmPublish skip detection that always reported "already publi…
timtebeek May 5, 2026
e69b586
JS: simplify npmPublish version match to contains
timtebeek May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions rewrite-javascript/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,9 +263,8 @@ val npmPublish = tasks.register<NpmTask>("npmPublish") {
.directory(file("rewrite"))
.redirectErrorStream(true)
.start()
process.waitFor()
val output = process.inputStream.bufferedReader().readText().trim()
val alreadyPublished = output.contains(versionToCheck)
val alreadyPublished = process.waitFor() == 0 && output.lines().any { it.trim() == versionToCheck }
Copy link
Copy Markdown
Contributor

@greg-at-moderne greg-at-moderne May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be contains instead of ==?

Copy link
Copy Markdown
Member Author

@timtebeek timtebeek May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Applied just now; ready to merge if you agree (feel free to push the button as I'm out for a bit here).

if (alreadyPublished) {
logger.lifecycle("Skipping npmPublish: @openrewrite/rewrite@$versionToCheck already published")
}
Expand Down
Loading
⚡