We currently have credentials for authenticating Agents, which is per backend:
TEST_JOB_SERVER_TOKEN
TPP_JOB_SERVER_TOKEN
etc
These are still, in fact, tokens that we get from job-server (a token per backend). They were previously also used by the controller sync loop to authenticate with the job-server API. However, we don't now have a sync loop, and we don't call job-server for anything, so the token name is confusing, and it doesn't need to be a token from job-server, it just needs to be a token that each agent sends (the agent's CONTROLLER_TASK_API_TOKEN variable), and the controller understands. It would be less confusingly named as something like TEST_AGENT_TOKEN.
We currently have credentials for authenticating Agents, which is per backend:
TEST_JOB_SERVER_TOKENTPP_JOB_SERVER_TOKENetc
These are still, in fact, tokens that we get from job-server (a token per backend). They were previously also used by the controller sync loop to authenticate with the job-server API. However, we don't now have a sync loop, and we don't call job-server for anything, so the token name is confusing, and it doesn't need to be a token from job-server, it just needs to be a token that each agent sends (the agent's CONTROLLER_TASK_API_TOKEN variable), and the controller understands. It would be less confusingly named as something like
TEST_AGENT_TOKEN.