[D&D] metadata slice 1879#2193
Merged
ashwin-pc merged 4 commits intoopensearch-project:mainfrom Aug 30, 2022
Merged
Conversation
abbyhu2000
force-pushed
the
brb_metadata_slice_1879
branch
from
80f3f24 to
2a25918
Compare
Codecov Report
@@ Coverage Diff @@
## main #2193 +/- ##
==========================================
- Coverage 67.22% 67.21% -0.02%
==========================================
Files 3100 3100
Lines 59564 59579 +15
Branches 9062 9064 +2
==========================================
+ Hits 40043 40047 +4
- Misses 17334 17346 +12
+ Partials 2187 2186 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ashwin-pc
reviewed
Aug 24, 2022
Member
ashwin-pc
left a comment
ashwin-pc
left a comment
There was a problem hiding this comment.
Nice change. Almost all my comments are stylistic
…sable the save button if not and show error messages. Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
abbyhu2000
force-pushed
the
brb_metadata_slice_1879
branch
from
2a25918 to
3c1da32
Compare
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
kavilla
approved these changes
Aug 25, 2022
| import { useTypedSelector, useTypedDispatch } from '../utils/state_management'; | ||
| import { setSaveState } from '../utils/state_management/metadata_slice'; | ||
|
|
||
| // TODO: Need to finalize the error messages |
Member
There was a problem hiding this comment.
do we have a follow-up issue for this? do we need ux insight here?
kavilla
reviewed
Aug 25, 2022
|
|
||
| // TODO: Need to finalize the error messages | ||
| if (isEmpty) { | ||
| errorMsg = 'The canvas is empty. Add some aggregations before saving.'; |
Member
There was a problem hiding this comment.
do we need to ping @KrooshalUX to get the final messages?
Member
Author
There was a problem hiding this comment.
@KrooshalUX Hi Kroosh, for the save button tooltip() error messages for wizard, have we finalized them? Thanks!
kavilla
previously approved these changes
Aug 25, 2022
Member
|
cool~ ship it! |
joshuarrrr
previously approved these changes
Aug 25, 2022
Member
joshuarrrr
left a comment
joshuarrrr
left a comment
There was a problem hiding this comment.
Awesome job on the feature!
abbyhu2000
dismissed stale reviews from joshuarrrr, kavilla, and ashwin-pc
via
20df493
abbyhu2000
force-pushed
the
brb_metadata_slice_1879
branch
from
202acd0 to
20df493
Compare
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
abbyhu2000
force-pushed
the
brb_metadata_slice_1879
branch
from
20df493 to
9f17933
Compare
AMoo-Miki
approved these changes
Aug 29, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 30, 2022
* Use metadata slice to save if the visualization is savable or not. Disable the save button if not and show error messages. Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Add some comments about store subscriber and editor state Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * create a seperate use_can_save hook Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> (cherry picked from commit 65005be)
kavilla
pushed a commit
that referenced
this pull request
Aug 31, 2022
* Use metadata slice to save if the visualization is savable or not. Disable the save button if not and show error messages. Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Add some comments about store subscriber and editor state Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * create a seperate use_can_save hook Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> (cherry picked from commit 65005be) Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add two new state in metadata slice, disable save button when the visualization is not savable and display error messages using tooltip.
Visualization is not savable when:
Issues Resolved
resolves #1879
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr