[D&D] Add index pattern info when loading embeddable#2363
Merged
ashwin-pc merged 1 commit intoopensearch-project:mainfrom Sep 15, 2022
Merged
Conversation
Since index pattern is not included in the visualization state anymore, need to add the index pattern information so the embeddable can be loaded correctly. Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
AMoo-Miki
approved these changes
Sep 15, 2022
seraphjiang
approved these changes
Sep 15, 2022
ashwin-pc
approved these changes
Sep 15, 2022
Codecov Report
@@ Coverage Diff @@
## main #2363 +/- ##
==========================================
- Coverage 66.55% 66.54% -0.01%
==========================================
Files 3170 3170
Lines 60316 60320 +4
Branches 9181 9181
==========================================
- Hits 40142 40140 -2
- Misses 17956 17986 +30
+ Partials 2218 2194 -24
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 15, 2022
Since index pattern is not included in the visualization state anymore, need to add the index pattern information so the embeddable can be loaded correctly. Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> (cherry picked from commit dc0d7d5)
ashwin-pc
pushed a commit
that referenced
this pull request
Sep 15, 2022
Since index pattern is not included in the visualization state anymore, need to add the index pattern information so the embeddable can be loaded correctly. Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> (cherry picked from commit dc0d7d5) Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
opensearch-trigger-bot bot
added a commit
that referenced
this pull request
Sep 15, 2022
Since index pattern is not included in the visualization state anymore, need to add the index pattern information so the embeddable can be loaded correctly. Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> (cherry picked from commit dc0d7d5) Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com> (cherry picked from commit 0720f14)
joshuarrrr
pushed a commit
that referenced
this pull request
Sep 16, 2022
Since index pattern is not included in the visualization state anymore, need to add the index pattern information so the embeddable can be loaded correctly. Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> (cherry picked from commit dc0d7d5) Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com> (cherry picked from commit 0720f14) Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
sipopo
pushed a commit
to sipopo/OpenSearch-Dashboards
that referenced
this pull request
Dec 16, 2022
Since index pattern is not included in the visualization state anymore, need to add the index pattern information so the embeddable can be loaded correctly. Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: Sergey V. Osipov <sipopo@yandex.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since index pattern is not included in the visualization state anymore, need to add the index pattern information so the embeddable can be loaded correctly on the dashboard.
Signed-off-by: abbyhu2000 abigailhu2000@gmail.com
Issues Resolved
resolves #2362
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr