[VizBuilder] Create a new wizard directly on a dashboard by abbyhu2000 · Pull Request #2384 · opensearch-project/OpenSearch-Dashboards

abbyhu2000 · 2022-09-17T01:01:57Z

Description

After selecting a dashboard, create a new wizard directly from the dashboard and have the option to add to that dashboard.

Signed-off-by: abbyhu2000 abigailhu2000@gmail.com

Issues Resolved

resolves #2381

Check List

codecov-commenter · 2022-09-17T01:47:09Z

Codecov Report

Merging #2384 (baaa10b) into main (a528965) will increase coverage by 0.03%.
The diff coverage is 72.54%.

@@            Coverage Diff             @@
##             main    #2384      +/-   ##
==========================================
+ Coverage   66.75%   66.78%   +0.03%     
==========================================
  Files        3200     3201       +1     
  Lines       60886    60914      +28     
  Branches     9250     9254       +4     
==========================================
+ Hits        40644    40682      +38     
+ Misses      18030    18019      -11     
- Partials     2212     2213       +1

Impacted Files	Coverage Δ
...cation/components/doc/use_opensearch_doc_search.ts	`90.90% <ø> (ø)`
...s/wizard/public/application/components/top_nav.tsx	`5.00% <0.00%> (-0.89%)`	⬇️
src/plugins/wizard/public/plugin.ts	`27.58% <ø> (ø)`
...rd/public/application/utils/get_top_nav_config.tsx	`66.66% <75.75%> (+62.82%)`	⬆️
...c/plugins/wizard/public/application/utils/mocks.ts	`100.00% <100.00%> (ø)`
src/plugins/expressions/public/mocks.tsx	`93.33% <0.00%> (+6.66%)`	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

joshuarrrr

partial review

ashwin-pc

Ship it 🚢

After selecting a dashboard, create a new wizard directly from the dashboard and have the option to add to that dashboard. Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

ananzh

LGTM

joshuarrrr

Looks great, thanks for cleaning up the existing implementation and adding some nice unit tests. A few minor questions and suggestions, but nothing blocking.

joshuarrrr · 2022-10-03T21:54:53Z

+    savedWizardVis = {
+      id: '1',
+      title: 'save wizard wiz title',
+      description: '',
+      visualizationState: '',
+      styleState: '',
+      version: 0,
+      copyOnSave: true,
+      searchSourceFields: {},
+      save: jest.fn().mockReturnValue('1'),
+    };


I wonder if there's some existing way to automock saved objects from their definitions... this definitely works, but seems like something you shouldn't really have to do.

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

opensearch-trigger-bot · 2022-10-28T20:52:25Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2384-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b75e07dd45d4d6b189fbd177ee5bad60a1d08505
# Push it to GitHub
git push --set-upstream origin backport/backport-2384-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2384-to-2.x.

…project#2384) * Create a new wizard directly on a dashboard After selecting a dashboard, create a new wizard directly from the dashboard and have the option to add to that dashboard. Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * hook change to solve browser warning Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Move onsave out from getTopNavConfig function and added unit tests Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Add changelog Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> (cherry picked from commit b75e07d)

…project#2384) * Create a new wizard directly on a dashboard After selecting a dashboard, create a new wizard directly from the dashboard and have the option to add to that dashboard. Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * hook change to solve browser warning Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Move onsave out from getTopNavConfig function and added unit tests Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Add changelog Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

…rd (#2384) (#2692)

…project#2384) * Create a new wizard directly on a dashboard After selecting a dashboard, create a new wizard directly from the dashboard and have the option to add to that dashboard. Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * hook change to solve browser warning Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Move onsave out from getTopNavConfig function and added unit tests Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Add changelog Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: Sergey V. Osipov <sipopo@yandex.ru>

abbyhu2000 force-pushed the add_wizard_to_dashboard branch from 2538d9d to e61d0ff Compare September 17, 2022 01:03

abbyhu2000 marked this pull request as ready for review September 17, 2022 01:07

abbyhu2000 requested a review from a team as a code owner September 17, 2022 01:07

abbyhu2000 self-assigned this Sep 17, 2022

abbyhu2000 changed the title ~~Create a new wizard directly on a dashboard~~ [VizBuilder] Create a new wizard directly on a dashboard Sep 17, 2022

abbyhu2000 added the vis builder label Sep 17, 2022

ashwin-pc reviewed Sep 19, 2022

View reviewed changes

Comment thread src/plugins/wizard/public/application/utils/get_top_nav_config.tsx Outdated

Comment thread src/plugins/wizard/public/application/utils/get_top_nav_config.tsx Outdated

abbyhu2000 force-pushed the add_wizard_to_dashboard branch 2 times, most recently from 099eb50 to 4329340 Compare September 28, 2022 00:51

joshuarrrr reviewed Sep 28, 2022

View reviewed changes

Comment thread yarn.lock Outdated

Comment thread src/plugins/wizard/public/application/components/top_nav.tsx Outdated

Comment thread src/plugins/wizard/public/application/components/top_nav.tsx Outdated

Comment thread src/plugins/wizard/public/application/components/top_nav.tsx Outdated

joshuarrrr mentioned this pull request Sep 28, 2022

[Meta] Workflow to catch/flag unintended yarn.lock updates in PRs #2429

Open

abbyhu2000 force-pushed the add_wizard_to_dashboard branch 2 times, most recently from 888a689 to 2de1e1f Compare October 3, 2022 17:40

ashwin-pc previously approved these changes Oct 4, 2022

View reviewed changes

Comment thread src/plugins/wizard/public/application/utils/get_top_nav_config.test.tsx

Comment thread src/plugins/wizard/public/application/utils/get_top_nav_config.tsx Outdated

abbyhu2000 dismissed ashwin-pc’s stale review via d5edab2 October 4, 2022 17:42

abbyhu2000 force-pushed the add_wizard_to_dashboard branch from 2de1e1f to d5edab2 Compare October 4, 2022 17:42

abbyhu2000 added 3 commits October 4, 2022 17:44

Create a new wizard directly on a dashboard

f71e452

After selecting a dashboard, create a new wizard directly from the dashboard and have the option to add to that dashboard. Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

hook change to solve browser warning

1d8d921

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

Move onsave out from getTopNavConfig function and added unit tests

15e9d23

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

abbyhu2000 force-pushed the add_wizard_to_dashboard branch 2 times, most recently from 0f900b3 to baaa10b Compare October 4, 2022 17:48

ananzh previously approved these changes Oct 4, 2022

View reviewed changes

joshuarrrr previously approved these changes Oct 4, 2022

View reviewed changes

Add changelog

dfd7809

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

abbyhu2000 dismissed stale reviews from joshuarrrr and ananzh via dfd7809 October 4, 2022 21:16

abbyhu2000 force-pushed the add_wizard_to_dashboard branch from baaa10b to dfd7809 Compare October 4, 2022 21:16

ananzh approved these changes Oct 4, 2022

View reviewed changes

joshuarrrr approved these changes Oct 4, 2022

View reviewed changes

abbyhu2000 merged commit b75e07d into opensearch-project:main Oct 4, 2022

abbyhu2000 mentioned this pull request Oct 7, 2022

[VisBuilder] When creating wizard from visualization page, provide additional options to add to new/existing dashboard, or add to library #2534

Open

abbyhu2000 added v2.4.0 'Issues and PRs related to version v2.4.0' backport 2.x labels Oct 28, 2022

abbyhu2000 added a commit that referenced this pull request Oct 29, 2022

[Backport 2.x] [VizBuilder] Create a new wizard directly on a dashboa…

7792e75

…rd (#2384) (#2692)

AMoo-Miki added the enhancement New feature or request label Nov 5, 2022

abbyhu2000 deleted the add_wizard_to_dashboard branch June 30, 2023 17:33

Conversation

abbyhu2000 commented Sep 17, 2022

Description

Issues Resolved

Check List

Uh oh!

codecov-commenter commented Sep 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

joshuarrrr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ashwin-pc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ananzh left a comment

Choose a reason for hiding this comment

Uh oh!

joshuarrrr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joshuarrrr Oct 3, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

opensearch-trigger-bot bot commented Oct 28, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov-commenter commented Sep 17, 2022 •

edited

Loading