[VisBuilder] Change classname prefix wiz to vb#2581
Merged
abbyhu2000 merged 1 commit intoopensearch-project:mainfrom Oct 17, 2022
Merged
[VisBuilder] Change classname prefix wiz to vb#2581abbyhu2000 merged 1 commit intoopensearch-project:mainfrom
abbyhu2000 merged 1 commit intoopensearch-project:mainfrom
Conversation
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
abbyhu2000
force-pushed
the
replace_wiz_classname
branch
from
c3dec8e to
c74552b
Compare
ashwin-pc
approved these changes
Oct 15, 2022
Member
ashwin-pc
left a comment
ashwin-pc
left a comment
There was a problem hiding this comment.
LGTM. Can you also add a screenshot of the page to the PR too?
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2581-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 db4343777c1129cc9c3d12b8670b4f251f9acadd
# Push it to GitHub
git push --set-upstream origin backport/backport-2581-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
abbyhu2000
added a commit
to abbyhu2000/OpenSearch-Dashboards
that referenced
this pull request
Oct 17, 2022
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
abbyhu2000
added a commit
that referenced
this pull request
Oct 18, 2022
abbyhu2000
added a commit
to abbyhu2000/OpenSearch-Dashboards
that referenced
this pull request
Nov 3, 2022
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
8 tasks
ananzh
pushed a commit
that referenced
this pull request
Nov 3, 2022
…#2770) * Change classname prefix wiz to vb (#2581) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Change wizard to vis_builder in file names and paths (#2587) Change all wizard reference in file names and paths to vis_builder Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Rename wizard to visBuilder in class name, type name and function name (#2639) Rname wizard to visBuilder Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [Vis Builder] Rename wizard on save modal and visualization table (#2645) * Rename wizard on save modal and visualization table Change the wizard reference in save modal title, toggle and visualization table Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Save visualization on save modal, VisBuilder for chart type Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * No experimental flag Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Change save object type, wizard id and name to visBuilder (#2673) * Change save object type, wizard ID and Name to visBuilder Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Rename wizard in functional tests Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Finalize plugin-id and plugin-name and saved-object-type Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Change official name to VisBuilder Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Delete migration Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Fix functional test Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Update snapshot Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
sipopo
pushed a commit
to sipopo/OpenSearch-Dashboards
that referenced
this pull request
Dec 16, 2022
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: Sergey V. Osipov <sipopo@yandex.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: abbyhu2000 abigailhu2000@gmail.com
Description
Replace class name prefixes wiz with vb for visualization builder.
Issues Resolved
solve bullet three of #1706
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr