Last Updated Timestamp for visbuilder savedobject is getting Generated#2628
Merged
ashwin-pc merged 2 commits intoopensearch-project:mainfrom Oct 26, 2022
Merged
Conversation
1064e92 to
9dc8436
Compare
ashwin-pc
reviewed
Oct 20, 2022
3fde491 to
edaff9d
Compare
Codecov Report
@@ Coverage Diff @@
## main #2628 +/- ##
==========================================
+ Coverage 66.78% 66.79% +0.01%
==========================================
Files 3207 3207
Lines 61175 61175
Branches 9329 9329
==========================================
+ Hits 40855 40863 +8
+ Misses 18084 18079 -5
+ Partials 2236 2233 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ashwin-pc
previously approved these changes
Oct 21, 2022
Member
|
@AbhishekReddy1127 This is great and such a cool bean. Currently PR is outdated and you could rebase it. I could approve again after you rebase and solve the conflict. |
Member
|
@AbhishekReddy1127 would you be able to rebase this PR? Let us know if you need some assistance with that! Thanks! |
Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>
89a0dfa
edaff9d to
89a0dfa
Compare
ashwin-pc
approved these changes
Oct 26, 2022
abbyhu2000
approved these changes
Oct 26, 2022
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2628-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a16fe4064257d72059307717a3e26023142d9b7a
# Push it to GitHub
git push --set-upstream origin backport/backport-2628-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 2, 2022
…ed (#2628) Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> (cherry picked from commit a16fe40) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
This was referenced Nov 2, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 2, 2022
…ed (#2628) Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> (cherry picked from commit a16fe40) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
kristenTian
pushed a commit
that referenced
this pull request
Nov 2, 2022
…ed (#2628) (#2742) Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> (cherry picked from commit a16fe40) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kristenTian
pushed a commit
that referenced
this pull request
Nov 2, 2022
…ed (#2628) (#2743) Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> (cherry picked from commit a16fe40) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sipopo
pushed a commit
to sipopo/OpenSearch-Dashboards
that referenced
this pull request
Dec 16, 2022
…ed (opensearch-project#2628) Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
alchemist51
pushed a commit
to alchemist51/OpenSearch-Dashboards
that referenced
this pull request
Jan 13, 2023
…ed (opensearch-project#2628) Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: AbhishekReddy1127 nallamsa@amazon.com
Description
The Savedobjects for the VisBuilder are generating the last updated timestamp

ScreenShot:
Issues Resolved
#2463
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr