[MD] Datasource management Edit/Update page UX updates

[mpabba3003]

Signed-off-by: mpabba3003 amazonmanideep@gmail.com

Description

Edit Data Source page

• Stay on update page after save changes [MD] Datasource update page bottom bar refactor #2622
• Endpoint section re-structuring [MD] Datasource update page endpoint field refactor #2621
• Delete button in danger color [MD] Datasource listing page delete button refactor #2616

Issues Resolved

#2621
#2622

SCREENSHOTS

Data.Sources.-.OpenSearch.Dashboards.2.mp4

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
  • yarn test:ftr
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[codecov-commenter]

Codecov Report

Merging #2629 (0d945ce) into main (33aed0a) will decrease coverage by 0.00%.
The diff coverage is 81.81%.

❗ Current head 0d945ce differs from pull request most recent head 7d335c3. Consider uploading reports for the commit 7d335c3 to get more accurate results

@@            Coverage Diff             @@
##             main    #2629      +/-   ##
==========================================
- Coverage   66.81%   66.80%   -0.01%     
==========================================
  Files        3207     3207              
  Lines       61137    61146       +9     
  Branches     9313     9314       +1     
==========================================
+ Hits        40849    40850       +1     
- Misses      18057    18063       +6     
- Partials     2231     2233       +2     

Impacted Files	Coverage Δ
src/plugins/data_source_management/public/types.ts	100.00% <ø> (ø)
...c/components/edit_data_source/edit_data_source.tsx	87.75% <80.00%> (-4.09%)	⬇️
...rce/components/edit_form/edit_data_source_form.tsx	91.45% <84.61%> (-1.14%)	⬇️
...s/osd-optimizer/src/node/node_auto_tranpilation.ts	83.67% <0.00%> (-4.09%)	⬇️
packages/osd-optimizer/src/node/cache.ts	50.00% <0.00%> (-2.78%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[zhongnansu]

Probably update PR title to something meaningful, e.g DataSource update page refactor ? @mpabba3003

[mpabba3003]

Probably update PR title to something meaningful, e.g DataSource update page refactor ? @mpabba3003

Done

[ashwin-pc]

Can we remove the snapshot tests for components like this? This diff does not make sense for the corresponding change in the test file and is a symptom of a bad snapshot. If we want to test the functionality of the component or its UI, we should leverage the functional test repo. Unit tests should only test the logic. the same comment applies to edit_data_source.

You need to test your components as a unit and in isolation, if one react component output changes only one unit test fails.

This principle breaks here because if EUI changes the markup for this component, all these tests will break.