[CCI] Adding second command to Install yarn step in Developer Guide#3633
Merged
abbyhu2000 merged 7 commits intoopensearch-project:mainfrom Mar 22, 2023
Merged
Conversation
kappassov
changed the title
Signed-off-by: kappassov <abayk0708@gmail.com>
kappassov
force-pushed
the
developer-guide-addition
branch
from
c71ad6a to
ea40110
Compare
joshuarrrr
reviewed
Mar 21, 2023
Member
joshuarrrr
left a comment
joshuarrrr
left a comment
There was a problem hiding this comment.
Excellent find, thanks!
If we're going to add that, I think we also want to include the link to the yarn version. One other small nit - otherwise looks great!
opensearch-project#3619) Issue Resolved: opensearch-project#3618 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
New reusable use_node scripts take care of selecting the correct Node.js binary based OSD_NODE_HOME, OSD_HOME, and whatever is in the PATH. It also takes care of finding the binary on FreeBSD. * The startup scripts check `OSD_NODE_HOME` and `NODE_HOME` before falling back to use the bundled or system-wide Node.js binary. * Update `package.json` to replace `node` with `use_node`. * Update file templates and shell scripts to internally use `use_node`. * Update the build scripts to copy `use_node` into releases * Make tests that execute node internally, honor the binary being used. Signed-off-by: Miki <miki@amazon.com>
* Fix the build failures * Removed some unused packages * Update gist url templates in Lychee's exclusion list Signed-off-by: Miki <miki@amazon.com>
…opensearch-project#3544) Refactor dev tool console to use opensearch-js client to interact with OpenSearch Signed-off-by: Su <szhongna@amazon.com>
Signed-off-by: kappassov <abayk0708@gmail.com>
joshuarrrr
approved these changes
Mar 22, 2023
Member
|
I set DCO to pass, as it was a false positive from a rebase commit. |
joshuarrrr
added
the
Skip-Changelog
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 22, 2023
…3633) * added prepare command Signed-off-by: kappassov <abayk0708@gmail.com> * Use mirrors to download Node.js binaries to escape sporadic 404 errors (#3619) Issue Resolved: #3618 Signed-off-by: Anan Zhuang <ananzh@amazon.com> * Allow selecting the Node.js binary OSD uses (#3508) New reusable use_node scripts take care of selecting the correct Node.js binary based OSD_NODE_HOME, OSD_HOME, and whatever is in the PATH. It also takes care of finding the binary on FreeBSD. * The startup scripts check `OSD_NODE_HOME` and `NODE_HOME` before falling back to use the bundled or system-wide Node.js binary. * Update `package.json` to replace `node` with `use_node`. * Update file templates and shell scripts to internally use `use_node`. * Update the build scripts to copy `use_node` into releases * Make tests that execute node internally, honor the binary being used. Signed-off-by: Miki <miki@amazon.com> * Clean up and rebuild @osd/pm (#3570) * Fix the build failures * Removed some unused packages * Update gist url templates in Lychee's exclusion list Signed-off-by: Miki <miki@amazon.com> * Refactor dev tool console to use opensearch-js client to send request (#3544) Refactor dev tool console to use opensearch-js client to interact with OpenSearch Signed-off-by: Su <szhongna@amazon.com> * updates after the 1st review Signed-off-by: kappassov <abayk0708@gmail.com> --------- Signed-off-by: kappassov <abayk0708@gmail.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Miki <miki@amazon.com> Signed-off-by: Su <szhongna@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Miki <miki@amazon.com> Co-authored-by: Zhongnan Su <szhongna@amazon.com> (cherry picked from commit b0146e7) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
abbyhu2000
pushed a commit
that referenced
this pull request
Mar 22, 2023
…3633) (#3651) * added prepare command * Use mirrors to download Node.js binaries to escape sporadic 404 errors (#3619) Issue Resolved: #3618 * Allow selecting the Node.js binary OSD uses (#3508) New reusable use_node scripts take care of selecting the correct Node.js binary based OSD_NODE_HOME, OSD_HOME, and whatever is in the PATH. It also takes care of finding the binary on FreeBSD. * The startup scripts check `OSD_NODE_HOME` and `NODE_HOME` before falling back to use the bundled or system-wide Node.js binary. * Update `package.json` to replace `node` with `use_node`. * Update file templates and shell scripts to internally use `use_node`. * Update the build scripts to copy `use_node` into releases * Make tests that execute node internally, honor the binary being used. * Clean up and rebuild @osd/pm (#3570) * Fix the build failures * Removed some unused packages * Update gist url templates in Lychee's exclusion list * Refactor dev tool console to use opensearch-js client to send request (#3544) Refactor dev tool console to use opensearch-js client to interact with OpenSearch * updates after the 1st review --------- (cherry picked from commit b0146e7) Signed-off-by: kappassov <abayk0708@gmail.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Miki <miki@amazon.com> Signed-off-by: Su <szhongna@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Miki <miki@amazon.com> Co-authored-by: Zhongnan Su <szhongna@amazon.com>
pjfitzgibbons
pushed a commit
to pjfitzgibbons/OpenSearch-Dashboards
that referenced
this pull request
Mar 24, 2023
…pensearch-project#3633) * added prepare command Signed-off-by: kappassov <abayk0708@gmail.com> * Use mirrors to download Node.js binaries to escape sporadic 404 errors (opensearch-project#3619) Issue Resolved: opensearch-project#3618 Signed-off-by: Anan Zhuang <ananzh@amazon.com> * Allow selecting the Node.js binary OSD uses (opensearch-project#3508) New reusable use_node scripts take care of selecting the correct Node.js binary based OSD_NODE_HOME, OSD_HOME, and whatever is in the PATH. It also takes care of finding the binary on FreeBSD. * The startup scripts check `OSD_NODE_HOME` and `NODE_HOME` before falling back to use the bundled or system-wide Node.js binary. * Update `package.json` to replace `node` with `use_node`. * Update file templates and shell scripts to internally use `use_node`. * Update the build scripts to copy `use_node` into releases * Make tests that execute node internally, honor the binary being used. Signed-off-by: Miki <miki@amazon.com> * Clean up and rebuild @osd/pm (opensearch-project#3570) * Fix the build failures * Removed some unused packages * Update gist url templates in Lychee's exclusion list Signed-off-by: Miki <miki@amazon.com> * Refactor dev tool console to use opensearch-js client to send request (opensearch-project#3544) Refactor dev tool console to use opensearch-js client to interact with OpenSearch Signed-off-by: Su <szhongna@amazon.com> * updates after the 1st review Signed-off-by: kappassov <abayk0708@gmail.com> --------- Signed-off-by: kappassov <abayk0708@gmail.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Miki <miki@amazon.com> Signed-off-by: Su <szhongna@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Miki <miki@amazon.com> Co-authored-by: Zhongnan Su <szhongna@amazon.com>
sikhote
pushed a commit
to sikhote/OpenSearch-Dashboards
that referenced
this pull request
Apr 24, 2023
…pensearch-project#3633) * added prepare command Signed-off-by: kappassov <abayk0708@gmail.com> * Use mirrors to download Node.js binaries to escape sporadic 404 errors (opensearch-project#3619) Issue Resolved: opensearch-project#3618 Signed-off-by: Anan Zhuang <ananzh@amazon.com> * Allow selecting the Node.js binary OSD uses (opensearch-project#3508) New reusable use_node scripts take care of selecting the correct Node.js binary based OSD_NODE_HOME, OSD_HOME, and whatever is in the PATH. It also takes care of finding the binary on FreeBSD. * The startup scripts check `OSD_NODE_HOME` and `NODE_HOME` before falling back to use the bundled or system-wide Node.js binary. * Update `package.json` to replace `node` with `use_node`. * Update file templates and shell scripts to internally use `use_node`. * Update the build scripts to copy `use_node` into releases * Make tests that execute node internally, honor the binary being used. Signed-off-by: Miki <miki@amazon.com> * Clean up and rebuild @osd/pm (opensearch-project#3570) * Fix the build failures * Removed some unused packages * Update gist url templates in Lychee's exclusion list Signed-off-by: Miki <miki@amazon.com> * Refactor dev tool console to use opensearch-js client to send request (opensearch-project#3544) Refactor dev tool console to use opensearch-js client to interact with OpenSearch Signed-off-by: Su <szhongna@amazon.com> * updates after the 1st review Signed-off-by: kappassov <abayk0708@gmail.com> --------- Signed-off-by: kappassov <abayk0708@gmail.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Miki <miki@amazon.com> Signed-off-by: Su <szhongna@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Miki <miki@amazon.com> Co-authored-by: Zhongnan Su <szhongna@amazon.com> Signed-off-by: David Sinclair <david@sinclair.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, Developer Guide has only one command listed in
yarninstallation step:npm i -g corepack. Writing only this one command seems to be incomplete and might be confusing for newcomers. Moreover, current description requires making extra step by going to the official installation docs without even trying Developer Guide's instructions.Issues Resolved
Adding the following command
corepack prepare yarn@<version> --activateto theyarninstallation paragraph will fulfill all minimum required steps to installyarn, and might help to avoid extra visitingyarndocumentation.Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr