Merged
Conversation
Signed-off-by: Josh Romero <rmerqg@amazon.com>
joshuarrrr
requested review from
AMoo-Miki,
BSFishy,
Flyingliuhub,
ZilongX,
abbyhu2000,
ananzh,
ashwin-pc,
curq,
kavilla,
kristenTian,
manasvinibs,
seanneumann,
zengyan-amazon and
zhongnansu
as code owners
Signed-off-by: Josh Romero <rmerqg@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #4941 +/- ##
=======================================
Coverage 66.39% 66.39%
=======================================
Files 3398 3398
Lines 64815 64815
Branches 10362 10362
=======================================
Hits 43033 43033
Misses 19221 19221
Partials 2561 2561
Flags with carried forward coverage won't be shown. Click here to find out more. |
kavilla
approved these changes
Sep 6, 2023
BSFishy
approved these changes
Sep 6, 2023
derek-ho
approved these changes
Sep 6, 2023
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-4941-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c035fb120eed8499e483e01f0d67d1c584732ec7
# Push it to GitHub
git push --set-upstream origin backport/backport-4941-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.xThen, create a pull request where the |
8 tasks
ashwin-pc
pushed a commit
that referenced
this pull request
Sep 7, 2023
* Bump OUI to `1.3.0` Signed-off-by: Josh Romero <rmerqg@amazon.com> * bump changelog Signed-off-by: Josh Romero <rmerqg@amazon.com> * Remove unecessary sass import CollapsibleNav vars now provided via theme import see opensearch-project/oui#968 Signed-off-by: Josh Romero <rmerqg@amazon.com> --------- Signed-off-by: Josh Romero <rmerqg@amazon.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bump OUI to
1.3.0Issues Resolved
fixes #4584
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr