Correct the generated path for downloading plugins by their names on Windows#4953
Merged
joshuarrrr merged 3 commits intoopensearch-project:mainfrom Sep 7, 2023
Merged
Conversation
AMoo-Miki
requested review from
BSFishy,
Flyingliuhub,
ZilongX,
abbyhu2000,
ananzh,
ashwin-pc,
curq,
joshuarrrr,
kavilla,
kristenTian,
manasvinibs,
seanneumann,
zengyan-amazon and
zhongnansu
as code owners
…Windows Signed-off-by: Miki <miki@amazon.com>
AMoo-Miki
force-pushed
the
fix-plugin-download-win
branch
from
d6e3476 to
699e940
Compare
AMoo-Miki
changed the title
Codecov Report
@@ Coverage Diff @@
## main #4953 +/- ##
==========================================
+ Coverage 66.39% 66.45% +0.06%
==========================================
Files 3398 3399 +1
Lines 64815 64915 +100
Branches 10362 10387 +25
==========================================
+ Hits 43035 43141 +106
+ Misses 19300 19210 -90
- Partials 2480 2564 +84
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 30 files with indirect coverage changes 📢 Have feedback on the report? Share it here. |
kavilla
previously approved these changes
Sep 7, 2023
Member
kavilla
left a comment
kavilla
left a comment
There was a problem hiding this comment.
Whoopsie. Good catch!
I think we can get this into 2.10
joshuarrrr
previously approved these changes
Sep 7, 2023
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla
approved these changes
Sep 7, 2023
joshuarrrr
approved these changes
Sep 7, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 7, 2023
…Windows (#4953) * Correct the generated path for downloading plugins by their names on Windows Signed-off-by: Miki <miki@amazon.com> * Update snapshot for unit test Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Add link for integration to lycheeexlude Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Miki <miki@amazon.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit 43fe5d5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 7, 2023
…Windows (#4953) * Correct the generated path for downloading plugins by their names on Windows Signed-off-by: Miki <miki@amazon.com> * Update snapshot for unit test Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Add link for integration to lycheeexlude Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Miki <miki@amazon.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit 43fe5d5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
kavilla
pushed a commit
that referenced
this pull request
Sep 8, 2023
…Windows (#4953) (#4971) * Correct the generated path for downloading plugins by their names on Windows Signed-off-by: Miki <miki@amazon.com> * Update snapshot for unit test Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Add link for integration to lycheeexlude Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Miki <miki@amazon.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit 43fe5d5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuarrrr
pushed a commit
that referenced
this pull request
Sep 8, 2023
…Windows (#4953) (#4972) * Correct the generated path for downloading plugins by their names on Windows Signed-off-by: Miki <miki@amazon.com> * Update snapshot for unit test Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Add link for integration to lycheeexlude Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Miki <miki@amazon.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit 43fe5d5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When OSD plugins are installed by their name, irrespective of the platform:
/tarhard-coded,/tar.However, experimenting with the URLs, these two worked for me:
This indicates that Windows plugins are not in fact placed in
/tar/but are placed in/zip/.Issues Resolved
Fixes #4952
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr