Skip to content

[Data Explorer] Fix share link of save search #5324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abbyhu2000 merged 1 commit into from
Oct 19, 2023
+6 −0
Merged

[Data Explorer] Fix share link of save search #5324

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/plugins/discover/public/application/components/top_nav/get_top_nav_links.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import { DiscoverState, setSavedSearchId } from '../../utils/state_management';
import { DOC_HIDE_TIME_COLUMN_SETTING, SORT_DEFAULT_ORDER_SETTING } from '../../../../common';
import { getSortForSearchSource } from '../../view_components/utils/get_sort_for_search_source';
import { getRootBreadcrumbs } from '../../helpers/breadcrumbs';
import { syncQueryStateWithUrl } from '../../../../../data/public';

export const getTopNavLinks = (
services: DiscoverViewServices,
Expand All @@ -35,6 +36,8 @@ export const getTopNavLinks = (
toastNotifications,
chrome,
store,
data: { query },
osdUrlStateStorage,
} = services;

const newSearch = {
Expand Down Expand Up @@ -108,6 +111,9 @@ export const getTopNavLinks = (
// set App state to clean
store!.dispatch({ type: setSavedSearchId.type, payload: id });

// starts syncing `_g` portion of url with query services
syncQueryStateWithUrl(query, osdUrlStateStorage);

return { id };
}
} catch (error) {
Expand Down
⚡