[OSCI][FIX] Discover: Fix the Subfields Display Issue

[MadaniKK]

Description

Fix the subfields display issue in Discover left nav bar.

Issues Resolved

Issue #5400 #5208

Screenshot

Before:

After:

Testing the changes

Check List

• [☑️ ] All tests pass
  • [ ☑️ ] yarn test:jest
  • yarn test:jest_integration
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• [☑️ ] Commits are signed per the DCO using --signoff

[ananzh]

This is great! I like all the discussions in the original issue and glad that you find such a simple yet smart solution. Just need a changelog update.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cf4f929) 66.98% compared to head (428f554) 66.98%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5429   +/-   ##
=======================================
  Coverage   66.98%   66.98%           
=======================================
  Files        3293     3293           
  Lines       63281    63281           
  Branches    10061    10061           
=======================================
+ Hits        42386    42391    +5     
+ Misses      18453    18450    -3     
+ Partials     2442     2440    -2     

Flag	Coverage Δ
Linux_1	35.24% <100.00%> (+<0.01%)	⬆️
Linux_2	55.21% <0.00%> (ø)
Linux_3	43.78% <100.00%> (+<0.01%)	⬆️
Linux_4	35.33% <0.00%> (ø)
Windows_1	35.27% <100.00%> (+<0.01%)	⬆️
Windows_2	55.18% <0.00%> (ø)
Windows_3	43.80% <100.00%> (+<0.01%)	⬆️
Windows_4	35.33% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[MadaniKK]

This is great! I like all the discussions in the original issue and glad that you find such a simple yet smart solution. Just need a changelog update.

Thank you for supporting me thru all the digging!

[willie-hung]

Hi @MadaniKK, it seems like your code editor auto format CHANGELOG.md when you are saving the file.

[MadaniKK]

Hi @MadaniKK, it seems like your code editor auto format CHANGELOG.md when you are saving the file.

Ah good catch, maybe I should redo the add changelog?

[willie-hung]

Yeah, me personally will use git revert the commit and push back to the remote. Hope it helps!

[willie-hung]

And if you are using vscode, you can find Save without Formatting in the Command Palette.

[MadaniKK]

And if you are using vscode, you can find Save without Formatting in the Command Palette.

I just tried this and It's still causing the same amount of change to the changelog.md 1 file changed, 9 insertions(+), 8 deletions(-)
I also checked that the changelog.md was 813 lines of code before and with my two newly added lines of code now it's 815 lines. And my autoformat on save probably just works in other codes files, not markdown files...So I am not sure why it's causing so many changes either :(

[willie-hung]

Have you closed the COMMIT_EDITMSG file? The revert operation completes upon closing the file (vscode). After reverting the commit, CHANGELOG.md should be restored to its initial state. At this point, you can add your changelog entry. Remember to save your changes without applying any formatting.

[ananzh]

@MadaniKK Does this also resolve #5208 right?

I checked the issue and it seems be already fixed by this PR. Because right now, the side nav will show all the nested field, therefore user can not choose the original object.