[MD] Create data source menu component able to be mount to nav bar#6082
Merged
BionIT merged 2 commits intoopensearch-project:mainfrom Mar 8, 2024
Merged
[MD] Create data source menu component able to be mount to nav bar#6082BionIT merged 2 commits intoopensearch-project:mainfrom
BionIT merged 2 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Lu Yu <nluyu@amazon.com>
Signed-off-by: Lu Yu <nluyu@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6082 +/- ##
=======================================
Coverage 67.13% 67.13%
=======================================
Files 3318 3321 +3
Lines 64037 64085 +48
Branches 10266 10280 +14
=======================================
+ Hits 42990 43025 +35
- Misses 18549 18555 +6
- Partials 2498 2505 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bandinib-amzn
approved these changes
Mar 8, 2024
Flyingliuhub
approved these changes
Mar 8, 2024
This was referenced Mar 8, 2024
This was referenced Mar 19, 2024
Closed
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 25, 2024
…6082) * create data source menu component Signed-off-by: Lu Yu <nluyu@amazon.com> * add changelog Signed-off-by: Lu Yu <nluyu@amazon.com> --------- Signed-off-by: Lu Yu <nluyu@amazon.com> (cherry picked from commit ae437b9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
BionIT
pushed a commit
that referenced
this pull request
Mar 25, 2024
…6082) (#6258) * create data source menu component Signed-off-by: Lu Yu <nluyu@amazon.com> * add changelog Signed-off-by: Lu Yu <nluyu@amazon.com> --------- Signed-off-by: Lu Yu <nluyu@amazon.com> (cherry picked from commit ae437b9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change add a new data source menu component which exposes function to allow plugins to consume and mount to the navigation bar.
Issues Resolved
This PR is to expose component without backporting to release branch yet.
Screenshot
dsmenu.mp4
Testing the changes
The following steps were performed in the recording above
data sourceswhich is passed in via selectedOptionCheck List
yarn test:jestyarn test:jest_integration