[Multiple Datasource] Add multi selectable data source component#6211
Merged
BionIT merged 15 commits intoopensearch-project:mainfrom Mar 26, 2024
Merged
[Multiple Datasource] Add multi selectable data source component#6211BionIT merged 15 commits intoopensearch-project:mainfrom
BionIT merged 15 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Lu Yu <nluyu@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6211 +/- ##
=======================================
Coverage 67.42% 67.43%
=======================================
Files 3362 3364 +2
Lines 65258 65311 +53
Branches 10524 10534 +10
=======================================
+ Hits 43999 44041 +42
- Misses 18701 18705 +4
- Partials 2558 2565 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
77 tasks
Signed-off-by: Lu Yu <nluyu@amazon.com>
Signed-off-by: Lu Yu <nluyu@amazon.com>
Closed
36 tasks
Signed-off-by: Lu Yu <nluyu@amazon.com>
Signed-off-by: Lu Yu <nluyu@amazon.com>
Signed-off-by: Lu Yu <nluyu@amazon.com>
Signed-off-by: Lu Yu <nluyu@amazon.com>
Signed-off-by: Lu Yu <nluyu@amazon.com>
| ]); | ||
|
|
||
| const input = screen.getByTestId('dataSourceMultiSelectFieldSearch'); | ||
| fireEvent.change(input, { target: { value: 'randome input' } }); |
Contributor
Author
There was a problem hiding this comment.
Thanks @Flyingliuhub! Good catch! Fixed typo in new commit!
Flyingliuhub
previously approved these changes
Mar 26, 2024
Signed-off-by: Lu Yu <nluyu@amazon.com>
Signed-off-by: Lu Yu <nluyu@amazon.com>
ZilongX
approved these changes
Mar 26, 2024
Flyingliuhub
approved these changes
Mar 26, 2024
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-6211-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6aa59b246a9b835387eba7a3895b58b9fc7ac74e
# Push it to GitHub
git push --set-upstream origin backport/backport-6211-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.xThen, create a pull request where the |
BionIT
added a commit
to BionIT/OpenSearch-Dashboards
that referenced
this pull request
Apr 2, 2024
…nsearch-project#6211) * add multi selectable data source component Signed-off-by: Lu Yu <nluyu@amazon.com> * update change log Signed-off-by: Lu Yu <nluyu@amazon.com> * add tests Signed-off-by: Lu Yu <nluyu@amazon.com> * add more test Signed-off-by: Lu Yu <nluyu@amazon.com> * refactor to add config Signed-off-by: Lu Yu <nluyu@amazon.com> * fix typo Signed-off-by: Lu Yu <nluyu@amazon.com> * update snapshot Signed-off-by: Lu Yu <nluyu@amazon.com> * add missing interface Signed-off-by: Lu Yu <nluyu@amazon.com> --------- Signed-off-by: Lu Yu <nluyu@amazon.com>
BionIT
added a commit
that referenced
this pull request
Apr 3, 2024
…) (#6318) * add multi selectable data source component * update change log * add tests * add more test * refactor to add config * fix typo * update snapshot * add missing interface --------- Signed-off-by: Lu Yu <nluyu@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change adds a new data source component which allows multi selections of data sources.
Issues Resolved
Fixes #6210
Screenshot
multiselect.mp4
Testing the changes
The following steps were performed in the recording above:
deselect allwill deselect all options and the badge icon should show 0Check List
yarn test:jestyarn test:jest_integration